Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2540)

Unified Diff: build/android/pylib/remote/device/remote_device_gtest_run.py

Issue 833403002: [Android] Create a dummy app to upload to Appurify for gtests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add gn Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/pylib/remote/device/remote_device_gtest_run.py
diff --git a/build/android/pylib/remote/device/remote_device_gtest_run.py b/build/android/pylib/remote/device/remote_device_gtest_run.py
index d40263db151d1be9ab96a0a7f8d15a1943d1cb21..49ddc9100023a1153f9c81a9f780ac1963b15ede 100644
--- a/build/android/pylib/remote/device/remote_device_gtest_run.py
+++ b/build/android/pylib/remote/device/remote_device_gtest_run.py
@@ -18,7 +18,6 @@ from pylib.remote.device import remote_device_helper
class RemoteDeviceGtestRun(remote_device_test_run.RemoteDeviceTestRun):
"""Run gtests and uirobot tests on a remote device."""
- DEFAULT_RUNNER_TYPE = 'robotium'
DEFAULT_RUNNER_PACKAGE = (
'org.chromium.native_test.ChromiumNativeTestInstrumentationTestRunner')
@@ -30,24 +29,22 @@ class RemoteDeviceGtestRun(remote_device_test_run.RemoteDeviceTestRun):
def _TriggerSetUp(self):
"""Set up the triggering of a test run."""
logging.info('Triggering test run.')
- self._app_id = self._UploadAppToDevice(self._test_instance.apk)
- if not self._env.runner_type:
- runner_type = self.DEFAULT_RUNNER_TYPE
- logging.info('Using default runner type: %s', self.DEFAULT_RUNNER_TYPE)
- else:
- runner_type = self._env.runner_type
+ if self._env.runner_type:
+ logging.warning('Ignoring configured runner_type "%s"',
+ self._env.runner_type)
if not self._env.runner_package:
runner_package = self.DEFAULT_RUNNER_PACKAGE
logging.info('Using default runner package: %s',
- self.DEFAULT_RUNNER_TYPE)
+ self.DEFAULT_RUNNER_PACKAGE)
else:
runner_package = self._env.runner_package
- self._test_id = self._UploadTestToDevice(runner_type)
- config_body = {'runner': runner_package}
- self._SetTestConfig(runner_type, config_body)
+ dummy_app_path = os.path.join(
+ constants.GetOutDirectory(), 'apks', 'remote_device_dummy.apk')
+ self._AmInstrumentTestSetup(dummy_app_path, self._test_instance.apk,
+ runner_package)
_INSTRUMENTATION_STREAM_LEADER = 'INSTRUMENTATION_STATUS: stream='

Powered by Google App Engine
This is Rietveld 408576698