Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1951)

Unified Diff: chrome/browser/sync/test/integration/sync_test.cc

Issue 8334030: Merge search engines sync data type with Preferences. Sync the default search provider. Add some ... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Merge to TOT and fixed additional conflicts from rsimha. Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/test/integration/sync_test.cc
===================================================================
--- chrome/browser/sync/test/integration/sync_test.cc (revision 109292)
+++ chrome/browser/sync/test/integration/sync_test.cc (working copy)
@@ -224,10 +224,6 @@
// TODO(sync): Remove this once sessions sync is enabled by default.
if (!cl->HasSwitch(switches::kEnableSyncTabs))
cl->AppendSwitch(switches::kEnableSyncTabs);
-
- // TODO(stevet): Remove this once search engines sync is enabled by default.
- if (!cl->HasSwitch(switches::kEnableSyncSearchEngines))
- cl->AppendSwitch(switches::kEnableSyncSearchEngines);
}
// static
@@ -703,6 +699,15 @@
UTF16ToASCII(browser()->GetSelectedTabContents()->GetTitle()));
}
+int SyncTest::NumberOfDefaultSyncItems() const {
+ // Just return the current number of basic sync items that are synced,
+ // including preferences, themes, and search engines.
+ // TODO(stevet): It would be nice if there was some mechanism for retrieving
+ // this sum from each data type without having to manually count and update
+ // this value.
+ return 7;
+}
+
void SyncTest::SetProxyConfig(net::URLRequestContextGetter* context_getter,
const net::ProxyConfig& proxy_config) {
base::WaitableEvent done(false, false);

Powered by Google App Engine
This is Rietveld 408576698