Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1046)

Issue 833363002: Exit fullscreen video for ChromeShell and ContentShell on Android (Closed)

Created:
5 years, 11 months ago by william.xie1
Modified:
5 years, 11 months ago
Reviewers:
Ted C, qinmin
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Exit fullscreen video for ChromeShell and ContentShell on Android Currently, when user press the exit full screen playback button, the ContentVideoView is still there, which blocking user switch to embeded video mode from full screen. BUG=446427 Committed: https://crrev.com/ada6cf09ce41e8fa2239c9e8a911a44552bced4d Cr-Commit-Position: refs/heads/master@{#310207}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellTab.java View 2 chunks +7 lines, -0 lines 0 comments Download
M content/shell/android/java/src/org/chromium/content_shell/Shell.java View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
william.xie1
5 years, 11 months ago (2015-01-06 09:05:53 UTC) #2
william.xie1
Hi Min, Would you please review the patch?
5 years, 11 months ago (2015-01-06 23:17:36 UTC) #3
qinmin
lgtm
5 years, 11 months ago (2015-01-06 23:34:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/833363002/1
5 years, 11 months ago (2015-01-07 00:43:17 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/33529)
5 years, 11 months ago (2015-01-07 00:50:03 UTC) #8
william.xie1
Hi Ted, Would you please review the patch?
5 years, 11 months ago (2015-01-07 01:11:18 UTC) #13
Ted C
lgtm
5 years, 11 months ago (2015-01-07 01:18:39 UTC) #15
william.xie1
Hi Ted, Would you please review the patch?
5 years, 11 months ago (2015-01-07 01:19:36 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/833363002/1
5 years, 11 months ago (2015-01-07 01:21:36 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-07 01:26:26 UTC) #20
commit-bot: I haz the power
5 years, 11 months ago (2015-01-07 01:28:30 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ada6cf09ce41e8fa2239c9e8a911a44552bced4d
Cr-Commit-Position: refs/heads/master@{#310207}

Powered by Google App Engine
This is Rietveld 408576698