Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 83333005: Add SK_ALWAYS_INLINE. (Closed)

Created:
7 years ago by mtklein
Modified:
7 years ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Add SK_ALWAYS_INLINE. I'm working on some code that's much faster when compiled by GCC than by Clang because GCC inlines more aggressively. Using SK_ATTRIBUTE(always_inline) on the appropriate methods narrows the performance gap considerably. This should work for MSVC, GCC, and Clang, otherwise falling back to "inline". BUG= R=reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=12364

Patch Set 1 #

Patch Set 2 : add usage #

Patch Set 3 : how do you spell judgment? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M include/core/SkPostConfig.h View 1 2 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mtklein
7 years ago (2013-11-22 16:36:53 UTC) #1
reed1
can you add a simple e.g. in the comments, to show how to use this ...
7 years ago (2013-11-22 16:47:16 UTC) #2
mtklein
On 2013/11/22 16:47:16, reed1 wrote: > can you add a simple e.g. in the comments, ...
7 years ago (2013-11-22 16:56:12 UTC) #3
mtklein
7 years ago (2013-11-22 16:56:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r12364 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698