net/ssl/ssl_config_service_unittest.cc - Issue 83333003: Add support for fetching Certificate Transparency SCTs over a TLS extension

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/ssl/ssl_config_service_unittest.cc

Issue 83333003: Add support for fetching Certificate Transparency SCTs over a TLS extension (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update tlslite patch Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/socket/ssl_client_socket_nss.cc ('K') | « net/ssl/ssl_config_service.cc ('k') | net/test/spawned_test_server/base_test_server.h » ('j') | net/test/spawned_test_server/base_test_server.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/ssl/ssl_config_service_unittest.cc

diff --git a/net/ssl/ssl_config_service_unittest.cc b/net/ssl/ssl_config_service_unittest.cc

index 42c8ae47b9f5613356c4eec81c8ea8a3afcd416f..9a68d53790ccf98f51bfa27c972fe2ea65b17d3e 100644

--- a/net/ssl/ssl_config_service_unittest.cc

+++ b/net/ssl/ssl_config_service_unittest.cc

@@ -69,6 +69,7 @@ TEST(SSLConfigServiceTest, ConfigUpdatesNotifyObservers) {

SSLConfig initial_config;

initial_config.rev_checking_enabled = true;

initial_config.false_start_enabled = false;

+ initial_config.signed_cert_timestamps_enabled = false;

initial_config.unrestricted_ssl3_fallback_enabled = false;

initial_config.version_min = SSL_PROTOCOL_VERSION_SSL3;

initial_config.version_max = SSL_PROTOCOL_VERSION_TLS1_1;

@@ -87,6 +88,10 @@ TEST(SSLConfigServiceTest, ConfigUpdatesNotifyObservers) {

EXPECT_CALL(observer, OnSSLConfigChanged()).Times(1);

mock_service->SetSSLConfig(initial_config);

+ initial_config.signed_cert_timestamps_enabled = true;

+ EXPECT_CALL(observer, OnSSLConfigChanged()).Times(1);

+ mock_service->SetSSLConfig(initial_config);

initial_config.unrestricted_ssl3_fallback_enabled = true;

EXPECT_CALL(observer, OnSSLConfigChanged()).Times(1);

mock_service->SetSSLConfig(initial_config);