Add support for fetching Certificate Transparency SCTs over a TLS extension

net/test/spawned_test_server/base_test_server.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/test/spawned_test_server/base_test_server.h"
 
 #include <string>
 #include <vector>
 
 #include "base/base64.h"
@@ skipping 380 matching lines @@
     scoped_ptr<base::ListValue> bulk_cipher_values(new base::ListValue());
     GetCiphersList(ssl_options_.bulk_ciphers, bulk_cipher_values.get());
     if (bulk_cipher_values->GetSize())
       arguments->Set("ssl-bulk-cipher", bulk_cipher_values.release());
     if (ssl_options_.record_resume)
       arguments->Set("https-record-resume", base::Value::CreateNullValue());
     if (ssl_options_.tls_intolerant != SSLOptions::TLS_INTOLERANT_NONE) {
       arguments->Set("tls-intolerant",
                      new base::FundamentalValue(ssl_options_.tls_intolerant));
     }
+    if (!ssl_options_.signed_cert_timestamps.empty()) {
+      arguments->SetString("signed-cert-timestamps",
+                           ssl_options_.signed_cert_timestamps);

[wtc, 2013/11/26 22:46:12]

An alternative design is to let ssl_options_.signed_cert_timestamps be a binary
string (so your unit tests can just use "test"), and perform the base64 encoding
here, when passing the second argument to arguments->SetString().

[ekasper, 2013/11/27 14:09:04]

That's much better, thanks! Done.

+    }
   }
 
   return GenerateAdditionalArguments(arguments);
 }
 
 bool BaseTestServer::GenerateAdditionalArguments(
     base::DictionaryValue* arguments) const {
   return true;
 }
 
 }  // namespace net