Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Side by Side Diff: net/ssl/ssl_config_service_unittest.cc

Issue 83333003: Add support for fetching Certificate Transparency SCTs over a TLS extension (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update tlslite patch Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/ssl/ssl_config_service.h" 5 #include "net/ssl/ssl_config_service.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "testing/gmock/include/gmock/gmock.h" 10 #include "testing/gmock/include/gmock/gmock.h"
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 EXPECT_CALL(observer, OnSSLConfigChanged()).Times(0); 62 EXPECT_CALL(observer, OnSSLConfigChanged()).Times(0);
63 mock_service->SetSSLConfig(initial_config); 63 mock_service->SetSSLConfig(initial_config);
64 64
65 mock_service->RemoveObserver(&observer); 65 mock_service->RemoveObserver(&observer);
66 } 66 }
67 67
68 TEST(SSLConfigServiceTest, ConfigUpdatesNotifyObservers) { 68 TEST(SSLConfigServiceTest, ConfigUpdatesNotifyObservers) {
69 SSLConfig initial_config; 69 SSLConfig initial_config;
70 initial_config.rev_checking_enabled = true; 70 initial_config.rev_checking_enabled = true;
71 initial_config.false_start_enabled = false; 71 initial_config.false_start_enabled = false;
72 initial_config.signed_cert_timestamps_enabled = false;
72 initial_config.unrestricted_ssl3_fallback_enabled = false; 73 initial_config.unrestricted_ssl3_fallback_enabled = false;
73 initial_config.version_min = SSL_PROTOCOL_VERSION_SSL3; 74 initial_config.version_min = SSL_PROTOCOL_VERSION_SSL3;
74 initial_config.version_max = SSL_PROTOCOL_VERSION_TLS1_1; 75 initial_config.version_max = SSL_PROTOCOL_VERSION_TLS1_1;
75 76
76 scoped_refptr<MockSSLConfigService> mock_service( 77 scoped_refptr<MockSSLConfigService> mock_service(
77 new MockSSLConfigService(initial_config)); 78 new MockSSLConfigService(initial_config));
78 MockSSLConfigServiceObserver observer; 79 MockSSLConfigServiceObserver observer;
79 mock_service->AddObserver(&observer); 80 mock_service->AddObserver(&observer);
80 81
81 // Test that the basic boolean preferences trigger updates. 82 // Test that the basic boolean preferences trigger updates.
82 initial_config.rev_checking_enabled = false; 83 initial_config.rev_checking_enabled = false;
83 EXPECT_CALL(observer, OnSSLConfigChanged()).Times(1); 84 EXPECT_CALL(observer, OnSSLConfigChanged()).Times(1);
84 mock_service->SetSSLConfig(initial_config); 85 mock_service->SetSSLConfig(initial_config);
85 86
86 initial_config.false_start_enabled = true; 87 initial_config.false_start_enabled = true;
87 EXPECT_CALL(observer, OnSSLConfigChanged()).Times(1); 88 EXPECT_CALL(observer, OnSSLConfigChanged()).Times(1);
88 mock_service->SetSSLConfig(initial_config); 89 mock_service->SetSSLConfig(initial_config);
89 90
91 initial_config.signed_cert_timestamps_enabled = true;
92 EXPECT_CALL(observer, OnSSLConfigChanged()).Times(1);
93 mock_service->SetSSLConfig(initial_config);
94
90 initial_config.unrestricted_ssl3_fallback_enabled = true; 95 initial_config.unrestricted_ssl3_fallback_enabled = true;
91 EXPECT_CALL(observer, OnSSLConfigChanged()).Times(1); 96 EXPECT_CALL(observer, OnSSLConfigChanged()).Times(1);
92 mock_service->SetSSLConfig(initial_config); 97 mock_service->SetSSLConfig(initial_config);
93 98
94 // Test that changing the SSL version range triggers updates. 99 // Test that changing the SSL version range triggers updates.
95 initial_config.version_min = SSL_PROTOCOL_VERSION_TLS1; 100 initial_config.version_min = SSL_PROTOCOL_VERSION_TLS1;
96 EXPECT_CALL(observer, OnSSLConfigChanged()).Times(1); 101 EXPECT_CALL(observer, OnSSLConfigChanged()).Times(1);
97 mock_service->SetSSLConfig(initial_config); 102 mock_service->SetSSLConfig(initial_config);
98 103
99 initial_config.version_max = SSL_PROTOCOL_VERSION_SSL3; 104 initial_config.version_max = SSL_PROTOCOL_VERSION_SSL3;
(...skipping 20 matching lines...) Expand all
120 // cipher suites disabled, triggers an update. 125 // cipher suites disabled, triggers an update.
121 disabled_ciphers.pop_back(); 126 disabled_ciphers.pop_back();
122 initial_config.disabled_cipher_suites = disabled_ciphers; 127 initial_config.disabled_cipher_suites = disabled_ciphers;
123 EXPECT_CALL(observer, OnSSLConfigChanged()).Times(1); 128 EXPECT_CALL(observer, OnSSLConfigChanged()).Times(1);
124 mock_service->SetSSLConfig(initial_config); 129 mock_service->SetSSLConfig(initial_config);
125 130
126 mock_service->RemoveObserver(&observer); 131 mock_service->RemoveObserver(&observer);
127 } 132 }
128 133
129 } // namespace net 134 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698