Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 83333002: Remove usage of deprecated APIs from d8 (Closed)

Created:
7 years, 1 month ago by jochen (gone - plz use gerrit)
Modified:
7 years, 1 month ago
Reviewers:
dcarney, Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Remove usage of deprecated APIs from d8 Also turn on deprecation warnings BUG=v8:3023 R=svenpanne@chromium.org, dcarney@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=18009

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -160 lines) Patch
M src/d8.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/d8.cc View 31 chunks +91 lines, -71 lines 0 comments Download
M src/d8.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M src/d8-debug.cc View 9 chunks +21 lines, -16 lines 0 comments Download
M src/d8-posix.cc View 28 chunks +94 lines, -65 lines 0 comments Download
M src/d8-windows.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
plz review
7 years, 1 month ago (2013-11-22 12:02:26 UTC) #1
Sven Panne
LGTM (rubberstamped)
7 years, 1 month ago (2013-11-22 12:15:33 UTC) #2
jochen (gone - plz use gerrit)
7 years, 1 month ago (2013-11-22 12:35:47 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18009 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698