Remove --plugins-metadata-server-url

chrome/browser/plugins/plugins_resource_service.cc

Index: chrome/browser/plugins/plugins_resource_service.cc
diff --git a/chrome/browser/plugins/plugins_resource_service.cc b/chrome/browser/plugins/plugins_resource_service.cc
index e1ac91a431c5122272eb3fd00a5c37cc50203232..0b99ce3524599109f65cd462d74777a4f3c7dc25 100644
--- a/chrome/browser/plugins/plugins_resource_service.cc
+++ b/chrome/browser/plugins/plugins_resource_service.cc
@@ -24,11 +24,6 @@ const int kTestCacheUpdateDelayMs = 2 * 60 * 1000;
 const char kPluginsServerUrl[] =
     "https://www.gstatic.com/chrome/config/plugins_2/";
 
-bool IsTest() {
-  return base::CommandLine::ForCurrentProcess()->HasSwitch(
-      switches::kPluginsMetadataServerURL);
-}
-
 GURL GetPluginsServerURL() {
   std::string filename;
 #if defined(OS_WIN)
@@ -44,11 +39,11 @@ GURL GetPluginsServerURL() {
   std::string test_url =
       base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
           switches::kPluginsMetadataServerURL);

[Bernhard Bauer, 2015/01/06 09:26:22]

Heh, I think you built this change on a platform that doesn't support plugin
installations, so this file isn't actually compiled. If it were compiled, there
would be an error here, because the switch has been removed.

[MRV, 2015/01/06 09:56:27]

Done.

-  return GURL(IsTest() ? test_url : kPluginsServerUrl + filename);
+  return GURL(kPluginsServerUrl + filename);
 }
 
 int GetCacheUpdateDelay() {

[Bernhard Bauer, 2015/01/06 09:26:22]

This can be inlined now.

[MRV, 2015/01/06 09:56:27]

Done.

[Bernhard Bauer, 2015/01/06 09:59:26]

I meant inlined as a transformation of the source code, i.e. replace calls to
this function with the returned value.

[MRV, 2015/01/06 11:07:11]

Done.

-  return IsTest() ? kTestCacheUpdateDelayMs : kCacheUpdateDelayMs;
+  return kCacheUpdateDelayMs;
 }
 
 }  // namespace