Remove --plugins-metadata-server-url

Remove --plugins-metadata-server-url

Changes made to remove the --plugins-metadata-server-url based code in the chrome

BUG=385715
Committed: https://crrev.com/43ed089c282ce524bca6767d7fddaa47b5d1e38e
Cr-Commit-Position: refs/heads/master@{#310088}

[MRV, 2015-01-06 08:46:55]

mohan.reddy@samsung.com changed reviewers:
+ thestig@chromium.org

[MRV, 2015-01-06 08:46:56]

PTAL

[Bernhard Bauer, 2015-01-06 09:26:21]

bauerb@chromium.org changed reviewers:
+ bauerb@chromium.org

[Bernhard Bauer, 2015-01-06 09:26:22]

https://codereview.chromium.org/833323002/diff/1/chrome/browser/plugins/plugi...
File chrome/browser/plugins/plugins_resource_service.cc (right):

https://codereview.chromium.org/833323002/diff/1/chrome/browser/plugins/plugi...
chrome/browser/plugins/plugins_resource_service.cc:41:
switches::kPluginsMetadataServerURL);
Heh, I think you built this change on a platform that doesn't support plugin
installations, so this file isn't actually compiled. If it were compiled, there
would be an error here, because the switch has been removed.

https://codereview.chromium.org/833323002/diff/1/chrome/browser/plugins/plugi...
chrome/browser/plugins/plugins_resource_service.cc:45: int GetCacheUpdateDelay()
{
This can be inlined now.

[MRV, 2015-01-06 09:56:28]

Thanks Bernhard Bauer for review.
I have incorporated the changes.
PTAL.

https://codereview.chromium.org/833323002/diff/1/chrome/browser/plugins/plugi...
File chrome/browser/plugins/plugins_resource_service.cc (right):

https://codereview.chromium.org/833323002/diff/1/chrome/browser/plugins/plugi...
chrome/browser/plugins/plugins_resource_service.cc:41:
switches::kPluginsMetadataServerURL);
On 2015/01/06 09:26:22, Bernhard Bauer wrote:
> Heh, I think you built this change on a platform that doesn't support plugin
> installations, so this file isn't actually compiled. If it were compiled,
there
> would be an error here, because the switch has been removed.

Done.

https://codereview.chromium.org/833323002/diff/1/chrome/browser/plugins/plugi...
chrome/browser/plugins/plugins_resource_service.cc:45: int GetCacheUpdateDelay()
{
On 2015/01/06 09:26:22, Bernhard Bauer wrote:
> This can be inlined now.

Done.

[Bernhard Bauer, 2015-01-06 09:59:26]

https://codereview.chromium.org/833323002/diff/1/chrome/browser/plugins/plugi...
File chrome/browser/plugins/plugins_resource_service.cc (right):

https://codereview.chromium.org/833323002/diff/1/chrome/browser/plugins/plugi...
chrome/browser/plugins/plugins_resource_service.cc:45: int GetCacheUpdateDelay()
{
On 2015/01/06 09:56:27, MRV wrote:
> On 2015/01/06 09:26:22, Bernhard Bauer wrote:
> > This can be inlined now.
> 
> Done.

I meant inlined as a transformation of the source code, i.e. replace calls to
this function with the returned value.

[MRV, 2015-01-06 11:07:11]

Thanks Bernhard Bauer for review, i have made suggested changes PTAL.

https://codereview.chromium.org/833323002/diff/1/chrome/browser/plugins/plugi...
File chrome/browser/plugins/plugins_resource_service.cc (right):

https://codereview.chromium.org/833323002/diff/1/chrome/browser/plugins/plugi...
chrome/browser/plugins/plugins_resource_service.cc:45: int GetCacheUpdateDelay()
{
On 2015/01/06 09:59:26, Bernhard Bauer wrote:
> On 2015/01/06 09:56:27, MRV wrote:
> > On 2015/01/06 09:26:22, Bernhard Bauer wrote:
> > > This can be inlined now.
> > 
> > Done.
> 
> I meant inlined as a transformation of the source code, i.e. replace calls to
> this function with the returned value.

Done.

[Bernhard Bauer, 2015-01-06 11:11:53]

lgtm

[MRV, 2015-01-06 11:20:54]

On 2015/01/06 11:11:53, Bernhard Bauer wrote:
> lgtm

Thanks Bernhard Bauer for quick review and feedback.

[MRV, 2015-01-06 11:21:04]

The CQ bit was checked by mohan.reddy@samsung.com

[commit-bot: I haz the power, 2015-01-06 11:22:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/833323002/40001

[commit-bot: I haz the power, 2015-01-06 12:22:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-06 12:22:23]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[MRV, 2015-01-06 12:38:44]

The CQ bit was checked by mohan.reddy@samsung.com

[commit-bot: I haz the power, 2015-01-06 12:39:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/833323002/60001

[commit-bot: I haz the power, 2015-01-06 14:25:43]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-01-06 14:26:30]

Patchset 4 (id:??) landed as
https://crrev.com/43ed089c282ce524bca6767d7fddaa47b5d1e38e
Cr-Commit-Position: refs/heads/master@{#310088}