Allow generator javascript test files to go anywhere in the source tree

Allow generator javascript test files to go anywhere in the source tree

- Allow javascript files anywhere in the source tree - specifically in the same directory as the implementation files.
- Copy the files to '<(PRODUCT_DIR)/test_data/...' so that cros can copy these where they need to go for cross-platform testing using 'ebuild'

R=jhawkins@chromium.org
BUG=90907, 89337
TEST=browser_tests --gtest_filter=OptionsWebUITest.*


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=106833

[James Hawkins, 2011-10-18 17:54:02]

Hmm, is this a step towards moving the test js files into the *actual* options
implementation directory, i.e., chrome/browser/resources/options?

[Sheridan Rawlins, 2011-10-18 19:04:59]

On 2011/10/18 17:54:02, James Hawkins wrote:
> Hmm, is this a step towards moving the test js files into the *actual* options
> implementation directory, i.e., chrome/browser/resources/options?

Yes.  I updated the Description accordingly with this:


Note: the ultimate goal is to have javascript files anywhere in the source tree
- specifically in the same directory as the implementation files. This first
commit rolls gyp and uses RULE_INPUT_DIRNAME to enable any directory, which
should unblock those wishing to group test files under subfolders, e.g. and
vets/ratchets the gyp changes. 

I will follow up with work for Bug 89337 to do the copies and move the
options.js into the chrome/browser/ui/webui/options directory as proof of that
fix.

[James Hawkins, 2011-10-18 19:06:31]

lgtm

[commit-bot: I haz the power, 2011-10-18 19:23:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scr@chromium.org/8333013/2001

[commit-bot: I haz the power, 2011-10-18 19:25:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scr@chromium.org/8333013/2001

[commit-bot: I haz the power, 2011-10-19 07:15:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scr@chromium.org/8333013/10014

[commit-bot: I haz the power, 2011-10-19 08:42:33]

The commit queue went berserk retrying too often for a
seemingly flaky test. Builder is linux_rel, revision is 106243, job name
was 8333013-10014 (retry) (retry) (retry) (retry).

[Sheridan Rawlins, 2011-10-21 04:13:43]

James, I took this the rest of the way and moved options.js over to
chrome/browser/ui/webui/options/options.js

Please re-review,

Thanks,

-SCR

[James Hawkins, 2011-10-21 20:48:13]

On 2011/10/21 04:13:43, Sheridan Rawlins wrote:
> James, I took this the rest of the way and moved options.js over to
> chrome/browser/ui/webui/options/options.js
> 

The file should be called options_unittest.js

[Sheridan Rawlins, 2011-10-21 21:18:15]

On 2011/10/21 20:48:13, James Hawkins wrote:
> On 2011/10/21 04:13:43, Sheridan Rawlins wrote:
> > James, I took this the rest of the way and moved options.js over to
> > chrome/browser/ui/webui/options/options.js
> > 
> 
> The file should be called options_unittest.js

I guess I had named it options_browsertest.js since it is built into
browser_tests.  Is _that_ an acceptable name?

[James Hawkins, 2011-10-21 23:32:11]

On 2011/10/21 21:18:15, Sheridan Rawlins wrote:
> On 2011/10/21 20:48:13, James Hawkins wrote:
> > On 2011/10/21 04:13:43, Sheridan Rawlins wrote:
> > > James, I took this the rest of the way and moved options.js over to
> > > chrome/browser/ui/webui/options/options.js
> > > 
> > 
> > The file should be called options_unittest.js
> 
> I guess I had named it options_browsertest.js since it is built into
> browser_tests.  Is _that_ an acceptable name?

Yeah, seems fine.  Once we get the necessary infrastructure, we should be able
to write real unit tests for JS.

[James Hawkins, 2011-10-21 23:35:49]

LGTM with nits.

http://codereview.chromium.org/8333013/diff/13009/chrome/common/chrome_paths.cc
File chrome/common/chrome_paths.cc (right):

http://codereview.chromium.org/8333013/diff/13009/chrome/common/chrome_paths....
chrome/common/chrome_paths.cc:287: if (!file_util::PathExists(cur))  // we don't
want to create this
Capitalize sentence and add period.

http://codereview.chromium.org/8333013/diff/13009/tools/gypv8sh.py
File tools/gypv8sh.py (right):

http://codereview.chromium.org/8333013/diff/13009/tools/gypv8sh.py#newcode45
tools/gypv8sh.py:45: subprocess.check_call(cmd, stdout=open(cxxoutfile,'w'))
Space between params.

[Sheridan Rawlins, 2011-10-22 00:09:11]

http://codereview.chromium.org/8333013/diff/13009/chrome/common/chrome_paths.cc
File chrome/common/chrome_paths.cc (right):

http://codereview.chromium.org/8333013/diff/13009/chrome/common/chrome_paths....
chrome/common/chrome_paths.cc:287: if (!file_util::PathExists(cur))  // we don't
want to create this
On 2011/10/21 23:35:49, James Hawkins wrote:
> Capitalize sentence and add period.

Done.

http://codereview.chromium.org/8333013/diff/13009/tools/gypv8sh.py
File tools/gypv8sh.py (right):

http://codereview.chromium.org/8333013/diff/13009/tools/gypv8sh.py#newcode45
tools/gypv8sh.py:45: subprocess.check_call(cmd, stdout=open(cxxoutfile,'w'))
On 2011/10/21 23:35:49, James Hawkins wrote:
> Space between params.

Done.

[commit-bot: I haz the power, 2011-10-22 00:09:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/scr@chromium.org/8333013/19003

[commit-bot: I haz the power, 2011-10-22 01:46:06]

Change committed as 106833