Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: Source/WebCore/page/Frame.cpp

Issue 8333006: Merge 97667 - Re-landing: window.webkitNotifications uses deallocated NotificationPresenter after... (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/874/
Patch Set: Created 9 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/WebCore/page/DOMWindow.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Simon Hausmann <hausmann@kde.org> 5 * 2000 Simon Hausmann <hausmann@kde.org>
6 * 2000 Stefan Schimanski <1Stein@gmx.de> 6 * 2000 Stefan Schimanski <1Stein@gmx.de>
7 * 2001 George Staikos <staikos@kde.org> 7 * 2001 George Staikos <staikos@kde.org>
8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
9 * Copyright (C) 2005 Alexey Proskuryakov <ap@nypop.com> 9 * Copyright (C) 2005 Alexey Proskuryakov <ap@nypop.com>
10 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 10 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
(...skipping 729 matching lines...) Expand 10 before | Expand all | Expand 10 after
740 if (m_page->focusController()->focusedFrame() == this) 740 if (m_page->focusController()->focusedFrame() == this)
741 m_page->focusController()->setFocusedFrame(0); 741 m_page->focusController()->setFocusedFrame(0);
742 742
743 m_page->decrementFrameCount(); 743 m_page->decrementFrameCount();
744 } 744 }
745 745
746 // FIXME: We should ideally allow existing Geolocation activities to con tinue 746 // FIXME: We should ideally allow existing Geolocation activities to con tinue
747 // when the Geolocation's iframe is reparented. 747 // when the Geolocation's iframe is reparented.
748 // See https://bugs.webkit.org/show_bug.cgi?id=55577 748 // See https://bugs.webkit.org/show_bug.cgi?id=55577
749 // and https://bugs.webkit.org/show_bug.cgi?id=52877 749 // and https://bugs.webkit.org/show_bug.cgi?id=52877
750 if (m_domWindow) 750 if (m_domWindow) {
751 m_domWindow->resetGeolocation(); 751 m_domWindow->resetGeolocation();
752 #if ENABLE(NOTIFICATIONS)
753 m_domWindow->resetNotifications();
754 #endif
755 }
752 756
753 #if ENABLE(MEDIA_STREAM) 757 #if ENABLE(MEDIA_STREAM)
754 if (m_mediaStreamFrameController) 758 if (m_mediaStreamFrameController)
755 m_mediaStreamFrameController->transferToNewPage(newPage); 759 m_mediaStreamFrameController->transferToNewPage(newPage);
756 #endif 760 #endif
757 m_page = newPage; 761 m_page = newPage;
758 762
759 if (newPage) 763 if (newPage)
760 newPage->incrementFrameCount(); 764 newPage->incrementFrameCount();
761 765
(...skipping 308 matching lines...) Expand 10 before | Expand all | Expand 10 after
1070 unsigned count = 0; 1074 unsigned count = 0;
1071 for (const Frame* frame = this; frame; frame = frame->tree()->traverseNext() ) { 1075 for (const Frame* frame = this; frame; frame = frame->tree()->traverseNext() ) {
1072 if (frame->document()) 1076 if (frame->document())
1073 count += frame->document()->wheelEventHandlerCount(); 1077 count += frame->document()->wheelEventHandlerCount();
1074 } 1078 }
1075 1079
1076 m_page->chrome()->client()->numWheelEventHandlersChanged(count); 1080 m_page->chrome()->client()->numWheelEventHandlersChanged(count);
1077 } 1081 }
1078 1082
1079 } // namespace WebCore 1083 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/WebCore/page/DOMWindow.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698