Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Unified Diff: gpu/command_buffer/service/buffer_manager.cc

Issue 833243008: Update from https://crrev.com/311145 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/service/buffer_manager.h ('k') | gpu/command_buffer/service/context_group.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/buffer_manager.cc
diff --git a/gpu/command_buffer/service/buffer_manager.cc b/gpu/command_buffer/service/buffer_manager.cc
index 7b1c90dfbb35d5c633987094b3e75d02b286f87a..94a252cafd533a9e78b47885d18c3bbd96d0e538 100644
--- a/gpu/command_buffer/service/buffer_manager.cc
+++ b/gpu/command_buffer/service/buffer_manager.cc
@@ -12,6 +12,7 @@
#include "gpu/command_buffer/service/feature_info.h"
#include "gpu/command_buffer/service/memory_tracking.h"
#include "ui/gl/gl_bindings.h"
+#include "ui/gl/gl_implementation.h"
namespace gpu {
namespace gles2 {
@@ -23,6 +24,7 @@ BufferManager::BufferManager(
new MemoryTypeTracker(memory_tracker, MemoryTracker::kManaged)),
feature_info_(feature_info),
allow_buffers_on_multiple_targets_(false),
+ allow_fixed_attribs_(false),
buffer_count_(0),
have_context_(true),
use_client_side_arrays_for_stream_buffers_(
@@ -251,10 +253,13 @@ void BufferManager::SetInfo(
Buffer* buffer, GLsizeiptr size, GLenum usage, const GLvoid* data) {
DCHECK(buffer);
memory_tracker_->TrackMemFree(buffer->size());
- bool is_client_side_array = IsUsageClientSideArray(usage);
- bool shadow = buffer->target() == GL_ELEMENT_ARRAY_BUFFER ||
- allow_buffers_on_multiple_targets_ ||
- is_client_side_array;
+ const bool is_client_side_array = IsUsageClientSideArray(usage);
+ const bool support_fixed_attribs =
+ gfx::GetGLImplementation() == gfx::kGLImplementationEGLGLES2;
+ const bool shadow = buffer->target() == GL_ELEMENT_ARRAY_BUFFER ||
+ allow_buffers_on_multiple_targets_ ||
+ (allow_fixed_attribs_ && !support_fixed_attribs) ||
+ is_client_side_array;
buffer->SetInfo(size, usage, shadow, data, is_client_side_array);
memory_tracker_->TrackMemAlloc(buffer->size());
}
« no previous file with comments | « gpu/command_buffer/service/buffer_manager.h ('k') | gpu/command_buffer/service/context_group.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698