Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 833243007: Refactor FakeServer::CreateDefaultPermanentItems() (Closed)

Created:
5 years, 11 months ago by mpawlowski
Modified:
5 years, 11 months ago
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, maxbogue+watch_chromium.org, zea+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor FakeServer::CreateDefaultPermanentItems() Removing some copy-paste code reuse. It's not that bad here, but in Opera we have more folders we fake this way and the copies start looking silly. BUG= Committed: https://crrev.com/908428a01742a93c4817a463cfd4e6c99fc56c0b Cr-Commit-Position: refs/heads/master@{#311066}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -17 lines) Patch
M sync/test/fake_server/fake_server.h View 1 chunk +2 lines, -0 lines 0 comments Download
M sync/test/fake_server/fake_server.cc View 2 chunks +14 lines, -17 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mpawlowski
5 years, 11 months ago (2015-01-12 16:07:54 UTC) #2
Andrew T Wilson (Slow)
lgtm
5 years, 11 months ago (2015-01-12 16:13:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/833243007/1
5 years, 11 months ago (2015-01-12 16:38:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-12 18:00:30 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-12 18:02:21 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/908428a01742a93c4817a463cfd4e6c99fc56c0b
Cr-Commit-Position: refs/heads/master@{#311066}

Powered by Google App Engine
This is Rietveld 408576698