Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 83323003: Remove usage of deprecated APIs from v8 itself (Closed)

Created:
7 years, 1 month ago by jochen (gone - plz use gerrit)
Modified:
7 years, 1 month ago
Reviewers:
dcarney, Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Remove usage of deprecated APIs from v8 itself Also turn on depreaction warnings BUG=v8:3023 R=svenpanne@chromium.org, dcarney@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=18008

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -77 lines) Patch
M src/allocation-tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/api.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M src/debug.cc View 6 chunks +10 lines, -8 lines 0 comments Download
M src/extensions/externalize-string-extension.cc View 5 chunks +10 lines, -6 lines 0 comments Download
M src/extensions/statistics-extension.cc View 2 chunks +52 lines, -41 lines 0 comments Download
M src/i18n.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/mksnapshot.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
plz review
7 years, 1 month ago (2013-11-22 12:00:45 UTC) #1
Sven Panne
LGTM (rubberstamped)
7 years, 1 month ago (2013-11-22 12:15:14 UTC) #2
jochen (gone - plz use gerrit)
7 years, 1 month ago (2013-11-22 12:29:09 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18008 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698