Issue 833163002: Added checks for use after free of PrefService

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 833163002: Added checks for use after free of PrefService (Closed)

Created:
5 years, 11 months ago by battre

Modified:
5 years, 11 months ago

Reviewers:
Bernhard Bauer

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Added checks for use after free of PrefService BUG=435208 Committed: https://crrev.com/0a69defef6c4de84db795a6d7ba0067c315250ef Cr-Commit-Position: refs/heads/master@{#309925}

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
	M	base/prefs/pref_service.cc	View		2 chunks	+14 lines, -0 lines	0 comments	Download

Total messages: 8 (2 generated)

battre

Hi Bernard, could you please review this CL? Thanks, Dominic

5 years, 11 months ago (2015-01-05 15:03:08 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/833163002/1

5 years, 11 months ago (2015-01-05 17:51:19 UTC) #6

commit-bot: I haz the power

5 years, 11 months ago (2015-01-05 18:51:43 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/0a69defef6c4de84db795a6d7ba0067c315250ef
Cr-Commit-Position: refs/heads/master@{#309925}