Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 83313002: Remove usage of deprecated APIs from samples (Closed)

Created:
7 years, 1 month ago by jochen (gone - plz use gerrit)
Modified:
7 years, 1 month ago
Reviewers:
Sven Panne, dcarney
CC:
v8-dev
Visibility:
Public.

Description

Remove usage of deprecated APIs from samples Also turn on deprecation warnings for samples BUG=v8:3023 R=dcarney@chromium.org, svenpanne@chromium.org LOG=n Committed: https://code.google.com/p/v8/source/detail?r=18007

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -64 lines) Patch
M samples/lineprocessor.cc View 9 chunks +18 lines, -13 lines 0 comments Download
M samples/process.cc View 13 chunks +40 lines, -23 lines 0 comments Download
M samples/samples.gyp View 1 chunk +0 lines, -4 lines 0 comments Download
M samples/shell.cc View 9 chunks +34 lines, -24 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
plz review
7 years, 1 month ago (2013-11-22 11:58:22 UTC) #1
dcarney
lgtm
7 years, 1 month ago (2013-11-22 12:02:00 UTC) #2
Sven Panne
LGTM (rubberstamped)
7 years, 1 month ago (2013-11-22 12:15:48 UTC) #3
jochen (gone - plz use gerrit)
7 years, 1 month ago (2013-11-22 12:26:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r18007 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698