Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 833043002: ui/chromeos: Fix the path to unit tests in the GN build file. (Closed)

Created:
5 years, 11 months ago by tfarina
Modified:
5 years, 11 months ago
Reviewers:
James Cook
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org, pkotwicz
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ui/chromeos: Fix the path to unit tests in the GN build file. BUG=None TEST=gn gen --args='os="chromeos"' out_gn/Debug R=jamescook@chromium.org Committed: https://crrev.com/6469995c37b66985e0877ba734fcab6108a35f9a Cr-Commit-Position: refs/heads/master@{#310211}

Patch Set 1 #

Patch Set 2 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M ui/chromeos/BUILD.gn View 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
tfarina
James, PTAL. As noted in -> https://codereview.chromium.org/738513002/#msg23 Peter, fyi.
5 years, 11 months ago (2015-01-04 19:29:50 UTC) #1
James Cook
LGTM (I presume ui_chromeos_unittests builds OK locally. The analyzer in the linux_chromium_chromeos_rel_ng tryjobs concluded that ...
5 years, 11 months ago (2015-01-05 18:22:13 UTC) #2
James Cook
On 2015/01/05 18:22:13, James Cook wrote: > LGTM > > (I presume ui_chromeos_unittests builds OK ...
5 years, 11 months ago (2015-01-05 20:42:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/833043002/20001
5 years, 11 months ago (2015-01-07 01:07:49 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-07 01:50:01 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-07 01:50:56 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6469995c37b66985e0877ba734fcab6108a35f9a
Cr-Commit-Position: refs/heads/master@{#310211}

Powered by Google App Engine
This is Rietveld 408576698