chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc - Issue 833033002: Remove dependency on //content from history DownloadDatabase

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc

Issue 833033002: Remove dependency on //content from history DownloadDatabase (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove obsolete #include Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/safe_browsing/incident_reporting/last_download_finder.h ('k') | chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc

diff --git a/chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc b/chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc

index cda5a88c4fc66390398e6ec53be4583715721ecf..58f44817b28e73d48c31268899d137b555ad3923 100644

--- a/chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc

+++ b/chrome/browser/safe_browsing/incident_reporting/last_download_finder.cc

@@ -19,7 +19,7 @@

#include "chrome/common/pref_names.h"

#include "chrome/common/safe_browsing/csd.pb.h"

#include "chrome/common/safe_browsing/download_protection_util.h"

-#include "content/public/browser/download_item.h"

+#include "components/history/core/browser/download_constants.h"

#include "content/public/browser/notification_details.h"

#include "content/public/browser/notification_service.h"

#include "content/public/browser/notification_source.h"

@@ -85,7 +85,7 @@ const history::DownloadRow* FindMostInteresting(

for (size_t i = 0; i < downloads.size(); ++i) {

const history::DownloadRow& row = downloads[i];

// Ignore incomplete downloads.

- if (row.state != content::DownloadItem::COMPLETE)

+ if (row.state != history::DownloadState::COMPLETE)

continue;

if (!most_recent_row || IsMoreInterestingThan(row, *most_recent_row))

most_recent_row = &row;