chrome/browser/ui/webui/downloads_dom_handler_browsertest.cc - Issue 833033002: Remove dependency on //content from history DownloadDatabase

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/webui/downloads_dom_handler_browsertest.cc

Issue 833033002: Remove dependency on //content from history DownloadDatabase (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove obsolete #include Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/auto_reset.h"	5 #include "base/auto_reset.h"

6 #include "base/files/scoped_temp_dir.h"	6 #include "base/files/scoped_temp_dir.h"

7 #include "base/json/json_reader.h"	7 #include "base/json/json_reader.h"

8 #include "base/prefs/pref_service.h"	8 #include "base/prefs/pref_service.h"

9 #include "base/values.h"	9 #include "base/values.h"

10 #include "chrome/browser/history/download_row.h"

11 #include "chrome/browser/profiles/profile.h"	10 #include "chrome/browser/profiles/profile.h"

12 #include "chrome/browser/ui/browser.h"	11 #include "chrome/browser/ui/browser.h"

13 #include "chrome/browser/ui/webui/downloads_dom_handler.h"	12 #include "chrome/browser/ui/webui/downloads_dom_handler.h"

14 #include "chrome/common/pref_names.h"	13 #include "chrome/common/pref_names.h"

15 #include "chrome/test/base/in_process_browser_test.h"	14 #include "chrome/test/base/in_process_browser_test.h"

16 #include "content/public/browser/web_contents.h"	15 #include "content/public/browser/web_contents.h"

17 #include "content/public/test/mock_download_item.h"	16 #include "content/public/test/mock_download_item.h"

18 #include "content/public/test/mock_download_manager.h"	17 #include "content/public/test/mock_download_manager.h"

19 #include "content/public/test/test_utils.h"	18 #include "content/public/test/test_utils.h"

20	19

(...skipping 257 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
278 // TODO(benjhayden): Test incognito, both downloads_list() and that on-record	277 // TODO(benjhayden): Test incognito, both downloads_list() and that on-record

279 // calls can't access off-record items.	278 // calls can't access off-record items.

280	279

281 // TODO(benjhayden): Test that bad download ids incoming from the javascript are	280 // TODO(benjhayden): Test that bad download ids incoming from the javascript are

282 // dropped on the floor.	281 // dropped on the floor.

283	282

284 // TODO(benjhayden): Test that IsTemporary() downloads are not shown.	283 // TODO(benjhayden): Test that IsTemporary() downloads are not shown.

285	284

286 // TODO(benjhayden): Test that RemoveObserver is called on all download items,	285 // TODO(benjhayden): Test that RemoveObserver is called on all download items,

287 // including items that crossed IsTemporary() and back.	286 // including items that crossed IsTemporary() and back.

OLD	NEW