Update unittest_apk target to allow specifying the name of the apk.

Update unittest_apk target to allow specifying the name of the apk.

This is useful when we want to build a template that will automatically
construct a test on desktop platforms and a test apk on Android.

R=cjhopman@chromium.org

Committed: https://crrev.com/e97f885871e033274a60af0d5fcd4e94f62ef92f
Cr-Commit-Position: refs/heads/master@{#310479}

[cjhopman, 2015-01-07 23:29:35]

lgtm

https://codereview.chromium.org/833003004/diff/1/build/config/android/rules.gni
File build/config/android/rules.gni (right):

https://codereview.chromium.org/833003004/diff/1/build/config/android/rules.g...
build/config/android/rules.gni:1444: test_suite_name =
get_label_info(invoker.unittests_dep, "name")
if the invoker defines both unittests_binary and apk_name, there will be an
error from test_suite_name being unused... :/

One pattern I've used to mark it as used is:
assert(test_suite_name != "" || true)

(and since we actually expect it to be nonempty, you could drop the || true)

You can leave it as is or do anything like that to mark it always used, either
is fine with me.

[qsr, 2015-01-08 08:58:16]

https://codereview.chromium.org/833003004/diff/1/build/config/android/rules.gni
File build/config/android/rules.gni (right):

https://codereview.chromium.org/833003004/diff/1/build/config/android/rules.g...
build/config/android/rules.gni:1444: test_suite_name =
get_label_info(invoker.unittests_dep, "name")
On 2015/01/07 23:29:35, cjhopman wrote:
> if the invoker defines both unittests_binary and apk_name, there will be an
> error from test_suite_name being unused... :/
> 
> One pattern I've used to mark it as used is:
> assert(test_suite_name != "" || true)
> 
> (and since we actually expect it to be nonempty, you could drop the || true)
> 
> You can leave it as is or do anything like that to mark it always used, either
> is fine with me.

Done.

[qsr, 2015-01-08 08:58:20]

The CQ bit was checked by qsr@chromium.org

[commit-bot: I haz the power, 2015-01-08 09:00:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/833003004/20001

[commit-bot: I haz the power, 2015-01-08 11:02:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-08 11:02:45]

Exceeded time limit waiting for builds to trigger.

[qsr, 2015-01-08 11:20:42]

The CQ bit was checked by qsr@chromium.org

[commit-bot: I haz the power, 2015-01-08 11:21:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/833003004/20001

[commit-bot: I haz the power, 2015-01-08 11:40:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-01-08 11:41:31]

Patchset 2 (id:??) landed as
https://crrev.com/e97f885871e033274a60af0d5fcd4e94f62ef92f
Cr-Commit-Position: refs/heads/master@{#310479}