Simplify isolate startup, push isolate init onto the prototype.

Simplify isolate startup, push isolate init onto the prototype.
Also correct the initialization of class non-static fields.

[John Lenz, 2011-10-18 16:13:10]

On 2011/10/18 16:12:24, John Lenz wrote:

This one is also going to wait until we have number on golem again.

[floitsch, 2011-10-21 22:57:53]

FYI.
Currently no data is shared between isolates. I'm not sure we actually need
this, and this change would move statics to the Isolate's prototype. I added
Kasper for his opinion on this.

If we want to have full performance keeping some fields in the prototype of the
class is probably not a good idea either. The objects will have different hidden
classes, and thus be less optimized (@Kasper: correct me if I'm wrong).

http://codereview.chromium.org/8330023/diff/1/compiler/java/com/google/dart/c...
File
compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java
(left):

http://codereview.chromium.org/8330023/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java:1595:
fieldName = AstUtil.newNameRef(new JsThisRef(), getJsName(element));
was this correct?

http://codereview.chromium.org/8330023/diff/1/compiler/java/com/google/dart/c...
File
compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java
(right):

http://codereview.chromium.org/8330023/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java:1587:
JsExpression qualifier =
AstUtil.newNameRef(getJsName(element.getEnclosingElement()).makeRef(),
"prototype");
100 chars

http://codereview.chromium.org/8330023/diff/1/compiler/java/com/google/dart/c...
compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java:1588:
fieldName = AstUtil.newNameRef(qualifier, getJsName(element));
Afaics fieldName is only used if defer == true, which means that the complete
'else' branch is currently unused.

[John Lenz, 2011-10-24 16:28:30]

On 2011/10/21 22:57:53, floitsch wrote:
> FYI.
> Currently no data is shared between isolates.

If you are saying, there is no shared state, then yes that is correct. And there
is still no shared state after this change.  However, the entire code base is
"shared data"

 I'm not sure we actually need
> this, and this change would move statics to the Isolate's prototype. I added
> Kasper for his opinion on this.
> 
> If we want to have full performance keeping some fields in the prototype of
the
> class is probably not a good idea either. The objects will have different
hidden
> classes, and thus be less optimized (@Kasper: correct me if I'm wrong).
> 
>
http://codereview.chromium.org/8330023/diff/1/compiler/java/com/google/dart/c...
> File
> compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java
> (left):
> 
>
http://codereview.chromium.org/8330023/diff/1/compiler/java/com/google/dart/c...
>
compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java:1595:
> fieldName = AstUtil.newNameRef(new JsThisRef(), getJsName(element));
> was this correct?

This was adding values to the global "this".  It was not corrected when the
value moved from the getter (with a proper this) to the isolate state.  These
should never have been moved as they are instance state not global(aka isolate)
state.

> 
>
http://codereview.chromium.org/8330023/diff/1/compiler/java/com/google/dart/c...
> File
> compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java
> (right):
> 
>
http://codereview.chromium.org/8330023/diff/1/compiler/java/com/google/dart/c...
>
compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java:1587:
> JsExpression qualifier =
> AstUtil.newNameRef(getJsName(element.getEnclosingElement()).makeRef(),
> "prototype");
> 100 chars
> 
>
http://codereview.chromium.org/8330023/diff/1/compiler/java/com/google/dart/c...
>
compiler/java/com/google/dart/compiler/backend/js/GenerateJavascriptAST.java:1588:
> fieldName = AstUtil.newNameRef(qualifier, getJsName(element));
> Afaics fieldName is only used if defer == true, which means that the complete
> 'else' branch is currently unused.