Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 832963002: Revert of cc: Remove tile and scale specific code from raster source (Closed)

Created:
5 years, 11 months ago by jdduke (slow)
Modified:
5 years, 11 months ago
Reviewers:
hendrikw, vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Remove tile and scale specific code from raster source (patchset #4 id:60001 of https://codereview.chromium.org/811953005/) Reason for revert: Broke the build due to collision with crrev.com/820743002. Probably just needs a rebase and constructor tweak, reverting for now to be safe. Original issue's description: > cc: Remove tile and scale specific code from raster source > > Fix a TODO I added a while back. Instead of calling SetMinContentsScale > and SetTileGridSize directly, pass these as parameters to constructor of the > PicturePile. > > Committed: https://crrev.com/6d1f2981f3204852a9189d0b6e7ad0b18659d68d > Cr-Commit-Position: refs/heads/master@{#309867} TBR=vmpstr@chromium.org,hendrikw@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/0dc47d774c6a2f4dd9d5c357c15cc67291f9ebfb Cr-Commit-Position: refs/heads/master@{#309868}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -36 lines) Patch
M cc/layers/picture_layer.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M cc/resources/display_list_recording_source.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/resources/display_list_recording_source.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M cc/resources/picture_pile.h View 3 chunks +3 lines, -5 lines 0 comments Download
M cc/resources/picture_pile.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M cc/resources/picture_pile_unittest.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M cc/resources/recording_source.h View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/test/fake_picture_pile.h View 1 chunk +1 line, -3 lines 0 comments Download
M cc/test/fake_picture_pile_impl.cc View 4 chunks +8 lines, -11 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jdduke (slow)
Created Revert of cc: Remove tile and scale specific code from raster source
5 years, 11 months ago (2015-01-03 02:05:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/832963002/1
5 years, 11 months ago (2015-01-03 02:06:25 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-03 02:07:15 UTC) #3
commit-bot: I haz the power
5 years, 11 months ago (2015-01-03 02:07:57 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0dc47d774c6a2f4dd9d5c357c15cc67291f9ebfb
Cr-Commit-Position: refs/heads/master@{#309868}

Powered by Google App Engine
This is Rietveld 408576698