Issue 832933006: Remove the media viewer component.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 832933006: Remove the media viewer component. (Closed)

Created:
5 years, 11 months ago by Elliot Glaysher

Modified:
5 years, 11 months ago

Reviewers:
Ben Goodger (Google), sky

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Remove the media viewer component. The media viewer appears to not have been orphaned a while back; the png viewer looks like it used to use this to provide a generalized zoom in/out/restore controls, but then it stopped using it and it remained in the tree. BUG=443439 R=sky@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a868d6a454d7869ece74aa39e8427ee4cb581fc7

Patch Set 1 #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -378 lines)			Patch
M	examples/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	examples/media_viewer/BUILD.gn	View	1 chunk	+0 lines, -36 lines	0 comments	Download
D	examples/media_viewer/media_viewer.cc	View	1 chunk	+0 lines, -328 lines	0 comments	Download
D	examples/media_viewer/media_viewer.mojom	View	1 chunk	+0 lines, -11 lines	0 comments	Download
M	examples/png_viewer/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	examples/png_viewer/png_viewer.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Elliot Glaysher

ben: I was talking with sky and he said I should check with you about ...

5 years, 11 months ago (2015-01-07 23:06:43 UTC) #2

Elliot Glaysher

5 years, 11 months ago (2015-01-07 23:58:30 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
a868d6a454d7869ece74aa39e8427ee4cb581fc7 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages