Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: Source/bindings/core/v8/V8ScriptRunnerTest.cpp

Issue 832933005: Oilpan: fix webkit unit tests following r187980. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/V8ScriptRunnerTest.cpp
diff --git a/Source/bindings/core/v8/V8ScriptRunnerTest.cpp b/Source/bindings/core/v8/V8ScriptRunnerTest.cpp
index b8ea14145bdf8d8b5d80ded771b88d4e05dcd90d..cce830cdf3e7e459fc0efa415e924fae546b36c3 100644
--- a/Source/bindings/core/v8/V8ScriptRunnerTest.cpp
+++ b/Source/bindings/core/v8/V8ScriptRunnerTest.cpp
@@ -72,13 +72,13 @@ public:
void setEmptyResource()
{
m_resourceRequest = WTF::adoptPtr(new ResourceRequest);
- m_resource = adoptPtrWillBeNoop(new ScriptResource(*m_resourceRequest.get(), "UTF-8"));
+ m_resource = ScriptResource::create(*m_resourceRequest.get(), "UTF-8");
}
void setResource()
{
m_resourceRequest = WTF::adoptPtr(new ResourceRequest(url()));
- m_resource = adoptPtrWillBeNoop(new ScriptResource(*m_resourceRequest.get(), "UTF-8"));
+ m_resource = ScriptResource::create(*m_resourceRequest.get(), "UTF-8");
}
protected:
@@ -123,8 +123,8 @@ TEST_F(V8ScriptRunnerTest, parseMemoryOption)
EXPECT_FALSE(m_resource->cachedMetadata(tagForCodeCache(m_resource.get())));
// The cached data is associated with the encoding.
ResourceRequest request(url());
- ScriptResource anotherResource(request, "UTF-16");
- EXPECT_FALSE(m_resource->cachedMetadata(tagForParserCache(&anotherResource)));
+ OwnPtrWillBeRawPtr<ScriptResource> anotherResource = ScriptResource::create(request, "UTF-16");
+ EXPECT_FALSE(m_resource->cachedMetadata(tagForParserCache(anotherResource.get())));
}
TEST_F(V8ScriptRunnerTest, parseOption)
@@ -135,8 +135,8 @@ TEST_F(V8ScriptRunnerTest, parseOption)
EXPECT_FALSE(m_resource->cachedMetadata(tagForCodeCache(m_resource.get())));
// The cached data is associated with the encoding.
ResourceRequest request(url());
- ScriptResource anotherResource(request, "UTF-16");
- EXPECT_FALSE(m_resource->cachedMetadata(tagForParserCache(&anotherResource)));
+ OwnPtrWillBeRawPtr<ScriptResource> anotherResource = ScriptResource::create(request, "UTF-16");
+ EXPECT_FALSE(m_resource->cachedMetadata(tagForParserCache(anotherResource.get())));
}
TEST_F(V8ScriptRunnerTest, codeOption)
@@ -147,8 +147,8 @@ TEST_F(V8ScriptRunnerTest, codeOption)
EXPECT_TRUE(m_resource->cachedMetadata(tagForCodeCache(m_resource.get())));
// The cached data is associated with the encoding.
ResourceRequest request(url());
- ScriptResource anotherResource(request, "UTF-16");
- EXPECT_FALSE(m_resource->cachedMetadata(tagForCodeCache(&anotherResource)));
+ OwnPtrWillBeRawPtr<ScriptResource> anotherResource = ScriptResource::create(request, "UTF-16");
+ EXPECT_FALSE(m_resource->cachedMetadata(tagForCodeCache(anotherResource.get())));
}
TEST_F(V8ScriptRunnerTest, codeCompressedOptions)

Powered by Google App Engine
This is Rietveld 408576698