Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 832933005: Oilpan: fix webkit unit tests following r187980. (Closed)

Created:
5 years, 11 months ago by sof
Modified:
5 years, 11 months ago
Reviewers:
haraken, oilpan-reviews
CC:
blink-reviews, blink-reviews-bindings_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, arv+blink, gavinp+loader_chromium.org, jochen (gone - plz use gerrit), marja
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: fix webkit unit tests following r187980. Avoid stack allocating heap-residing ScriptResource objects. TBR=oilpan-reviews,haraken BUG=441130 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187998

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -11 lines) Patch
M Source/bindings/core/v8/ScriptStreamerTest.cpp View 1 chunk +1 line, -1 line 3 comments Download
M Source/bindings/core/v8/V8ScriptRunnerTest.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
M Source/core/fetch/ResourceFetcher.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/ScriptResource.h View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
sof
Please take a look. That we allow GarbageCollected<>-derived objects to be stack allocated is troubling. ...
5 years, 11 months ago (2015-01-07 21:49:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/832933005/1
5 years, 11 months ago (2015-01-07 21:50:38 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=187998
5 years, 11 months ago (2015-01-07 21:51:16 UTC) #4
haraken
LGTM https://codereview.chromium.org/832933005/diff/1/Source/bindings/core/v8/ScriptStreamerTest.cpp File Source/bindings/core/v8/ScriptStreamerTest.cpp (right): https://codereview.chromium.org/832933005/diff/1/Source/bindings/core/v8/ScriptStreamerTest.cpp#newcode70 Source/bindings/core/v8/ScriptStreamerTest.cpp:70: , m_resource(ScriptResource::create(m_resourceRequest, "UTF-8").leakPtr()) Who deletes the leaked m_resource?
5 years, 11 months ago (2015-01-08 01:17:21 UTC) #5
sof
https://codereview.chromium.org/832933005/diff/1/Source/bindings/core/v8/ScriptStreamerTest.cpp File Source/bindings/core/v8/ScriptStreamerTest.cpp (right): https://codereview.chromium.org/832933005/diff/1/Source/bindings/core/v8/ScriptStreamerTest.cpp#newcode70 Source/bindings/core/v8/ScriptStreamerTest.cpp:70: , m_resource(ScriptResource::create(m_resourceRequest, "UTF-8").leakPtr()) On 2015/01/08 01:17:21, haraken wrote: > ...
5 years, 11 months ago (2015-01-08 06:17:14 UTC) #6
haraken
5 years, 11 months ago (2015-01-08 06:18:00 UTC) #7
Message was sent while issue was closed. 
https://codereview.chromium.org/832933005/diff/1/Source/bindings/core/v8/Scri...
File Source/bindings/core/v8/ScriptStreamerTest.cpp (right):

https://codereview.chromium.org/832933005/diff/1/Source/bindings/core/v8/Scri...
Source/bindings/core/v8/ScriptStreamerTest.cpp:70: ,
m_resource(ScriptResource::create(m_resourceRequest, "UTF-8").leakPtr())
On 2015/01/08 06:17:14, sof wrote:
> On 2015/01/08 01:17:21, haraken wrote:
> > 
> > Who deletes the leaked m_resource?
> 
> See comment on the next line.

ah, ok.

Powered by Google App Engine
This is Rietveld 408576698