Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 832933004: Prevent landmines.py from deleting your source directory. (Closed)

Created:
5 years, 11 months ago by johnme
Modified:
5 years, 11 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prevent landmines.py from deleting your source directory. Previously, if CHROMIUM_OUT_DIR was set but blank, it could (and did!) delete your entire source directory, including .git folder. BUG=446921 Committed: https://crrev.com/89d303ac3e23adf4ecff08e459a6bdf6b81ff033 Cr-Commit-Position: refs/heads/master@{#311326}

Patch Set 1 #

Patch Set 2 : Make blank CHROMIUM_OUT_DIR fatal #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M build/landmines.py View 1 1 chunk +5 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
johnme
5 years, 11 months ago (2015-01-07 18:46:28 UTC) #2
scottmg
How did you end up with an empty variable? I think I would prefer an ...
5 years, 11 months ago (2015-01-07 19:48:19 UTC) #3
johnme
On 2015/01/07 19:48:19, scottmg wrote: > How did you end up with an empty variable? ...
5 years, 11 months ago (2015-01-07 20:28:41 UTC) #4
scottmg
lgtm
5 years, 11 months ago (2015-01-13 20:28:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/832933004/20001
5 years, 11 months ago (2015-01-13 20:33:36 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-13 21:29:09 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-13 21:30:08 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/89d303ac3e23adf4ecff08e459a6bdf6b81ff033
Cr-Commit-Position: refs/heads/master@{#311326}

Powered by Google App Engine
This is Rietveld 408576698