Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1244)

Issue 83293002: Add #include <vector> to accelerators_gtk.h (Closed)

Created:
7 years, 1 month ago by alextaran1
Modified:
7 years, 1 month ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, Alexander Potapenko
Base URL:
https://src.chromium.org/chrome/trunk/src/
Visibility:
Public.

Description

Add #include <vector> to accelerators_gtk.h This file uses std::vector but does not include corresponding header file. R=erg@chromium.org BUG=82098 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236823

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/ui/gtk/accelerators_gtk.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
alextaran1
I'm working on building chromium with libc++ (http://libcxx.llvm.org/), but adding libc++'s headers to the include ...
7 years, 1 month ago (2013-11-22 11:38:52 UTC) #1
Elliot Glaysher
iwyu lgtm.
7 years, 1 month ago (2013-11-22 18:26:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alextaran@chromium.org/83293002/1
7 years, 1 month ago (2013-11-22 19:31:49 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-22 20:56:48 UTC) #4
Message was sent while issue was closed.
Change committed as 236823

Powered by Google App Engine
This is Rietveld 408576698