Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: Source/core/animation/LengthStyleInterpolation.cpp

Issue 832873002: Animation: Remove ASSERT_NOT_REACHED from LengthStyleInterpolation (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/animation/InterpolableValue.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/animation/LengthStyleInterpolation.cpp
diff --git a/Source/core/animation/LengthStyleInterpolation.cpp b/Source/core/animation/LengthStyleInterpolation.cpp
index 225341dfc0876cfe39b9750c05c7999889598e30..f0fa1c309697b35933ff56b7dd685df19ae5340e 100644
--- a/Source/core/animation/LengthStyleInterpolation.cpp
+++ b/Source/core/animation/LengthStyleInterpolation.cpp
@@ -95,7 +95,7 @@ PassRefPtrWillBeRawPtr<CSSPrimitiveValue> LengthStyleInterpolation::interpolable
switch (unitTypeCount) {
case 0:
- ASSERT_NOT_REACHED();
dstockwell 2015/01/04 23:54:16 Shouldn't we leave the ASSERT_NOT_REACHED here?
dstockwell 2015/01/04 23:54:16 Shouldn't we leave the ASSERT_NOT_REACHED here?
evemj (not active) 2015/01/05 02:28:47 Done.
evemj (not active) 2015/01/05 02:28:48 Done.
Eric Willigers 2015/01/05 02:32:22 Doug may have intended the following:- ASSERT_N
evemj (not active) 2015/01/05 04:36:57 Done.
+ return CSSPrimitiveValue::create(0, CSSPrimitiveValue::CSS_PX);
case 1:
for (size_t i = 0; i < CSSPrimitiveValue::LengthUnitTypeCount; i++) {
const InterpolableNumber *subValueType = toInterpolableNumber(listOfTypes->get(i));
« no previous file with comments | « Source/core/animation/InterpolableValue.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698