Issue 83283002: Android: change native pointer types from int to long in src/printing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 83283002: Android: change native pointer types from int to long in src/printing (Closed)

Created:
7 years, 1 month ago by cimamoglu (inactive)

Modified:
7 years, 1 month ago

Reviewers:
bulach, cimamoglu1, Vitaly Buka (NO REVIEWS)

CC:
chromium-reviews, whywhat

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Android: change native pointer types from int to long in src/printing BUG=317523 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236820

Patch Set 2 : Add jni_generator_ptr_type to gyp #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
M	printing/android/java/src/org/chromium/printing/PrintingContext.java	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	printing/printing.gyp	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	printing/printing_context_android.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

bulach

lgtm, thanks! you'll need to tweak the "printing_jni_headers" target: https://code.google.com/p/chromium/codesearch#chromium/src/printing/printing.gyp&q=printing%20gyp&sq=package:chromium&type=cs&l=335 to add a variable: 'jni_generator_ptr_type': ...

7 years, 1 month ago (2013-11-22 11:38:37 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cimamoglu@chromium.org/83283002/50001

7 years, 1 month ago (2013-11-22 18:32:06 UTC) #6

Message was sent while issue was closed.

Change committed as 236820

Expand Messages | Collapse Messages

Issue 83283002: Android: change native pointer types from int to long in src/printing (Closed)

Description

Patch Set 1 #

Patch Set 2 : Add jni_generator_ptr_type to gyp #

Messages