Optimize String.prototype.includes

Optimize String.prototype.includes

BUG=v8:3807
LOG=Y

[arv (Not doing code reviews), 2015-01-14 16:10:15]

arv@chromium.org changed reviewers:
+ arv@chromium.org

[arv (Not doing code reviews), 2015-01-14 16:10:16]

https://codereview.chromium.org/832713009/diff/1/src/harmony-string.js
File src/harmony-string.js (right):

https://codereview.chromium.org/832713009/diff/1/src/harmony-string.js#newcod...
src/harmony-string.js:108: var searchStr = TO_STRING_INLINE(searchString);
searchStr -> searchString

https://codereview.chromium.org/832713009/diff/1/src/harmony-string.js#newcod...
src/harmony-string.js:111: var searchLen = searchStr.length;
searchLen -> searchLength

https://codereview.chromium.org/832713009/diff/1/src/harmony-string.js#newcod...
src/harmony-string.js:114: if (pos > len) pos = len;
else if here?

[impinball, 2015-01-15 13:34:39]

On 2015/01/14 16:10:16, arv wrote:
> https://codereview.chromium.org/832713009/diff/1/src/harmony-string.js
> File src/harmony-string.js (right):
> 
>
https://codereview.chromium.org/832713009/diff/1/src/harmony-string.js#newcod...
> src/harmony-string.js:114: if (pos > len) pos = len;
> else if here?

I do agree that it makes more sense here. (Not my patch, though.)

[ziyunfei, 2015-01-19 06:39:14]

Optimize String.prototype.includes

BUG=v8:3807
LOG=Y
R=arv@chromium.org

[arv (Not doing code reviews), 2015-07-09 16:25:45]

The CQ bit was checked by arv@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-09 16:26:00]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/832713009/20001

[commit-bot: I haz the power, 2015-07-09 16:27:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-09 16:27:09]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/...)
  v8_linux64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/7557)
  v8_linux_arm_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/5941)
  v8_linux_dbg on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg/builds/6528)
  v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/7565)
  v8_win64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel/builds/6516)

(exceeded global retry quota)