Issue 832683005: Move the network service source-of-truth from Mojo to Chromium.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 832683005: Move the network service source-of-truth from Mojo to Chromium. (Closed)

Created:
5 years, 11 months ago by ppi

Modified:
5 years, 11 months ago

Reviewers:
jamesr

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Move the network service source-of-truth from Mojo to Chromium. This patch changes the roll scripts so that: - mojo/services/network is now pulled from Chromium into Mojo - mojo/services/network/public is *not* pulled from Mojo into Chromium anymore A corresponding Chromium change[1] updates mojo/services/network to ToT Mojo. [1] https://codereview.chromium.org/858093002/ BUG=450356 R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/371d089ce6e874afaa5f1f542b1e6da7184b4abb

Patch Set 1 #

Patch Set 2 : Rebase. #

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	mojo/tools/roll/rev_sdk.py	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	mojo/tools/roll/update_from_chromium.py	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ppi

5 years, 11 months ago (2015-01-21 16:23:26 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
371d089ce6e874afaa5f1f542b1e6da7184b4abb (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages