Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4262)

Unified Diff: chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc

Issue 832593003: Removed hangup testing from AppRTC test. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc
diff --git a/chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc b/chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc
index d75455c0710603d89deddb2f1d6fe03c09230aa8..ada2b1ddb6e2a00319b076e4b4bb3bc785580481 100644
--- a/chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc
+++ b/chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc
@@ -155,11 +155,6 @@ class WebRtcApprtcBrowserTest : public WebRtcTestBase {
tab_contents);
}
- bool WaitForCallToHangUp(content::WebContents* tab_contents) {
- return test::PollingWaitUntil(kIsApprtcCallUpJavascript, "false",
- tab_contents);
- }
-
bool EvalInJavascriptFile(content::WebContents* tab_contents,
const base::FilePath& path) {
std::string javascript;
@@ -190,11 +185,6 @@ class WebRtcApprtcBrowserTest : public WebRtcTestBase {
return true;
}
- bool HangUpApprtcCall(content::WebContents* tab_contents) {
- // This is the same as clicking the Hangup button in the AppRTC call.
- return content::ExecuteScript(tab_contents, "hangup()");
- }
-
base::FilePath GetSourceDir() {
base::FilePath source_dir;
PathService::Get(base::DIR_SOURCE_ROOT, &source_dir);
@@ -260,11 +250,6 @@ IN_PROC_BROWSER_TEST_F(WebRtcApprtcBrowserTest, MANUAL_WorksOnApprtc) {
ASSERT_TRUE(DetectRemoteVideoPlaying(left_tab));
ASSERT_TRUE(DetectRemoteVideoPlaying(right_tab));
- ASSERT_TRUE(HangUpApprtcCall(left_tab));
-
- ASSERT_TRUE(WaitForCallToHangUp(left_tab));
- ASSERT_TRUE(WaitForCallToHangUp(right_tab));
-
chrome::CloseWebContents(browser(), left_tab, false);
chrome::CloseWebContents(browser(), right_tab, false);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698