Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(579)

Issue 832583004: Suppress data races on FLAGS_quic_attach_ack_notifiers_to_packets (Closed)

Created:
5 years, 11 months ago by Alexander Potapenko
Modified:
5 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Suppress data races on FLAGS_quic_attach_ack_notifiers_to_packets BUG=448688 TBR=rtenneti@chromium.org NOTRY=true Committed: https://crrev.com/5635a13b7f50b34afd29688002ef85ba6a00af0f Cr-Commit-Position: refs/heads/master@{#311447}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build/sanitizers/tsan_suppressions.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Alexander Potapenko
TBR
5 years, 11 months ago (2015-01-14 10:17:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/832583004/1
5 years, 11 months ago (2015-01-14 10:19:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-14 10:30:02 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5635a13b7f50b34afd29688002ef85ba6a00af0f Cr-Commit-Position: refs/heads/master@{#311447}
5 years, 11 months ago (2015-01-14 10:31:05 UTC) #7
ramant (doing other things)
Missed the race. Fixed it in https://codereview.chromium.org/849123003/ LGTM
5 years, 11 months ago (2015-01-15 02:40:08 UTC) #8
ramant (doing other things)
5 years, 11 months ago (2015-01-16 01:51:08 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/856673002/ by rtenneti@chromium.org.

The reason for reverting is: This bug is fixed in the following release.
Reverting this change.

https://codereview.chromium.org/849123003/.

Powered by Google App Engine
This is Rietveld 408576698