Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 83253002: Dispose external string resource on heap teardown. (Closed)

Created:
7 years, 1 month ago by Yang
Modified:
7 years, 1 month ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Visibility:
Public.

Description

Dispose external string resource on heap teardown. R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18001

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M src/heap.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
7 years, 1 month ago (2013-11-22 10:43:33 UTC) #1
Benedikt Meurer
lgtm
7 years, 1 month ago (2013-11-22 10:45:44 UTC) #2
Yang
7 years, 1 month ago (2013-11-22 10:52:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18001 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698