Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 832503002: [bindings] Eliminate remaining traces of Handle<> from the generated binding code. (Closed)

Created:
5 years, 11 months ago by vivekg_samsung
Modified:
5 years, 11 months ago
Reviewers:
haraken, vivekg, Jens Widell
CC:
arv+blink, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[bindings] Eliminate remaining traces of Handle<> from the generated binding code. R=haraken@chromium.org R=jl@opera.com BUG=424445 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187744

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M Source/bindings/scripts/v8_types.py View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/core/V8TestDictionary.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterfaceNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestObject.cpp View 13 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
vivekg
PTAL, thanks!
5 years, 11 months ago (2014-12-29 13:48:31 UTC) #2
haraken
LGTM
5 years, 11 months ago (2014-12-29 13:52:05 UTC) #3
Jens Widell
LGTM
5 years, 11 months ago (2014-12-29 13:53:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/832503002/1
5 years, 11 months ago (2014-12-29 14:13:59 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2014-12-29 15:42:27 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187744

Powered by Google App Engine
This is Rietveld 408576698