Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Unified Diff: build/android/pylib/base/test_run_factory.py

Issue 832493005: Add Instrumentation test support to remote device (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/pylib/base/test_run_factory.py
diff --git a/build/android/pylib/base/test_run_factory.py b/build/android/pylib/base/test_run_factory.py
index 3f00caaceb4d628cb5d0712c55fa6b7be416add1..10f5386cc146b596c7a60ff6c06162e8f351a668 100644
--- a/build/android/pylib/base/test_run_factory.py
+++ b/build/android/pylib/base/test_run_factory.py
@@ -9,6 +9,7 @@ from pylib.local.device import local_device_environment
from pylib.local.device import local_device_instrumentation_test_run
from pylib.remote.device import remote_device_environment
from pylib.remote.device import remote_device_gtest_run
+from pylib.remote.device import remote_device_instrumentation_run
from pylib.remote.device import remote_device_uirobot_run
from pylib.uirobot import uirobot_test_instance
@@ -25,7 +26,11 @@ def CreateTestRun(_args, env, test_instance, error_func):
if isinstance(env, remote_device_environment.RemoteDeviceEnvironment):
if isinstance(test_instance, gtest_test_instance.GtestTestInstance):
return remote_device_gtest_run.RemoteDeviceGtestRun(env, test_instance)
- # TODO(rnephew): Add remote_device instrumentation test runs.
+ if isinstance(test_instance,
+ instrumentation_test_instance.InstrumentationTestInstance):
+ return (remote_device_instrumentation_run
+ .RemoteDeviceInstrumentationRun(env, test_instance))
+
if isinstance(test_instance, uirobot_test_instance.UirobotTestInstance):
return remote_device_uirobot_run.RemoteDeviceUirobotRun(
env, test_instance)

Powered by Google App Engine
This is Rietveld 408576698