Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Issue 83243005: Inline performance-critical methods on SkAlphaRuns (Closed)

Created:
7 years, 1 month ago by mtklein
Modified:
7 years, 1 month ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Inline performance-critical methods on SkAlphaRuns. Clang needs to be forced to inline add, so we do that. GCC on desktop bench conf time old new diff diffP draw_coverage_false 8888 c 236.08 212.01 +24.07 +10.2% draw_coverage_true 8888 c 125.67 104.49 +21.18 +16.9% GCC on N5 bench conf time old new diff diffP draw_coverage_false 8888 c 566.33 529.96 +36.37 +6.4% draw_coverage_true 8888 c 315.39 293.85 +21.54 +6.8% Clang on desktop bench conf time old new diff diffP draw_coverage_false 8888 c 337.37 330.63 +6.74 +2.0% draw_coverage_true 8888 c 126.87 119.32 +7.55 +6.0% BUG= R=reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=12370

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -108 lines) Patch
M src/core/SkAlphaRuns.cpp View 1 chunk +0 lines, -105 lines 0 comments Download
M src/core/SkAntiRun.h View 2 chunks +103 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mtklein
Sadly, this is ~100% of the speedup I'm seeing on my other branch.
7 years, 1 month ago (2013-11-22 21:24:00 UTC) #1
reed1
lgtm
7 years, 1 month ago (2013-11-22 21:25:09 UTC) #2
mtklein
7 years, 1 month ago (2013-11-22 21:25:58 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r12370 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698