Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 832403002: experimental skp_to_pdf_md5 program. (Closed)

Created:
5 years, 11 months ago by hal.canary
Modified:
5 years, 11 months ago
Reviewers:
djsollen, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

experimental skp_to_pdf_md5 program. This program takes a list of Skia Picture (SKP) files and renders each as a multipage PDF, then prints out the MD5 checksum of the PDF file. This can be used to verify that changes to the PDF backend will not change PDF output. Committed: https://skia.googlesource.com/skia/+/abe4baa2c3ce329048064f4de8aedf33b5c0861a

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -0 lines) Patch
A experimental/tools/skp_to_pdf_md5.cpp View 1 chunk +153 lines, -0 lines 3 comments Download
M gyp/experimental.gyp View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
hal.canary
PTAL
5 years, 11 months ago (2015-01-05 16:03:42 UTC) #2
djsollen
lgtm https://codereview.chromium.org/832403002/diff/1/experimental/tools/skp_to_pdf_md5.cpp File experimental/tools/skp_to_pdf_md5.cpp (right): https://codereview.chromium.org/832403002/diff/1/experimental/tools/skp_to_pdf_md5.cpp#newcode36 experimental/tools/skp_to_pdf_md5.cpp:36: static bool operator<(const SkString& a, const SkString& b) ...
5 years, 11 months ago (2015-01-05 16:40:43 UTC) #3
hal.canary
https://codereview.chromium.org/832403002/diff/1/experimental/tools/skp_to_pdf_md5.cpp File experimental/tools/skp_to_pdf_md5.cpp (right): https://codereview.chromium.org/832403002/diff/1/experimental/tools/skp_to_pdf_md5.cpp#newcode36 experimental/tools/skp_to_pdf_md5.cpp:36: static bool operator<(const SkString& a, const SkString& b) { ...
5 years, 11 months ago (2015-01-05 16:46:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/832403002/1
5 years, 11 months ago (2015-01-05 16:46:40 UTC) #6
reed1
https://codereview.chromium.org/832403002/diff/1/experimental/tools/skp_to_pdf_md5.cpp File experimental/tools/skp_to_pdf_md5.cpp (right): https://codereview.chromium.org/832403002/diff/1/experimental/tools/skp_to_pdf_md5.cpp#newcode36 experimental/tools/skp_to_pdf_md5.cpp:36: static bool operator<(const SkString& a, const SkString& b) { ...
5 years, 11 months ago (2015-01-05 16:52:12 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-05 16:55:28 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/abe4baa2c3ce329048064f4de8aedf33b5c0861a

Powered by Google App Engine
This is Rietveld 408576698