content/app/content_main_runner.cc - Issue 832393003: [gin] Fingerprint the V8 snapshot files on Windows and verify before loading the snapshot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/app/content_main_runner.cc

Issue 832393003: [gin] Fingerprint the V8 snapshot files on Windows and verify before loading the snapshot. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/app/content_main_runner.cc

diff --git a/content/app/content_main_runner.cc b/content/app/content_main_runner.cc

index 05e45bd791c07773c4ec25089d299245cefb9ab7..d142f35879c5e849aaffa6c577c199efac27f7b6 100644

--- a/content/app/content_main_runner.cc

+++ b/content/app/content_main_runner.cc

@@ -730,14 +730,14 @@ class ContentMainRunnerImpl : public ContentMainRunner {

CHECK(gin::IsolateHolder::LoadV8SnapshotFD(v8_natives_fd,

v8_snapshot_fd));

} else {

- CHECK(gin::IsolateHolder::LoadV8Snapshot());

+ CHECK(gin::IsolateHolder::LoadAndVerifyV8Snapshot());

}

#endif // V8_USE_EXTERNAL_STARTUP_DATA

#else

CHECK(base::i18n::InitializeICU());

#ifdef V8_USE_EXTERNAL_STARTUP_DATA

- CHECK(gin::IsolateHolder::LoadV8Snapshot());

+ CHECK(gin::IsolateHolder::LoadAndVerifyV8Snapshot());

#endif // V8_USE_EXTERNAL_STARTUP_DATA

#endif // OS_ANDROID

« no previous file with comments | « no previous file | gin/DEPS » ('j') | gin/fingerprint/fingerprint_v8_snapshot.py » ('J')