gin/public/isolate_holder.h - Issue 832393003: [gin] Fingerprint the V8 snapshot files on Windows and verify before loading the snapshot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gin/public/isolate_holder.h

Issue 832393003: [gin] Fingerprint the V8 snapshot files on Windows and verify before loading the snapshot. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address grt's comments Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gin/public/isolate_holder.h

diff --git a/gin/public/isolate_holder.h b/gin/public/isolate_holder.h

index b12734c4413c377ebcd6318b41fddd2b3ba721dd..09f2126353571669a775abaac4eedff382e1ccb1 100644

--- a/gin/public/isolate_holder.h

+++ b/gin/public/isolate_holder.h

@@ -51,10 +51,10 @@ class GIN_EXPORT IsolateHolder {

// thread.

void RemoveRunMicrotasksObserver();

-#ifdef V8_USE_EXTERNAL_STARTUP_DATA

+#if defined(V8_USE_EXTERNAL_STARTUP_DATA)

static bool LoadV8SnapshotFD(int natives_fd, int snapshot_fd);

static bool LoadV8Snapshot();

-#endif // V8_USE_EXTERNAL_STARTUP_DATA

+#endif // defined(V8_USE_EXTERNAL_STARTUP_DATA)

static void GetV8ExternalSnapshotData(const char** natives_data_out,

int* natives_size_out,

const char** snapshot_data_out,

« gin/isolate_holder.cc ('K') | « gin/isolate_holder.cc ('k') | no next file » | no next file with comments »