Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: content/app/content_main_runner.cc

Issue 832393003: [gin] Fingerprint the V8 snapshot files on Windows and verify before loading the snapshot. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix comment Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | gin/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/public/app/content_main_runner.h" 5 #include "content/public/app/content_main_runner.h"
6 6
7 #include <stdlib.h> 7 #include <stdlib.h>
8 8
9 #include "base/allocator/allocator_extension.h" 9 #include "base/allocator/allocator_extension.h"
10 #include "base/at_exit.h" 10 #include "base/at_exit.h"
(...skipping 703 matching lines...) Expand 10 before | Expand all | Expand 10 after
714 RegisterContentSchemes(true); 714 RegisterContentSchemes(true);
715 715
716 #if defined(OS_ANDROID) 716 #if defined(OS_ANDROID)
717 int icudata_fd = base::GlobalDescriptors::GetInstance()->MaybeGet( 717 int icudata_fd = base::GlobalDescriptors::GetInstance()->MaybeGet(
718 kAndroidICUDataDescriptor); 718 kAndroidICUDataDescriptor);
719 if (icudata_fd != -1) 719 if (icudata_fd != -1)
720 CHECK(base::i18n::InitializeICUWithFileDescriptor(icudata_fd)); 720 CHECK(base::i18n::InitializeICUWithFileDescriptor(icudata_fd));
721 else 721 else
722 CHECK(base::i18n::InitializeICU()); 722 CHECK(base::i18n::InitializeICU());
723 723
724 #ifdef V8_USE_EXTERNAL_STARTUP_DATA 724 #if defined(V8_USE_EXTERNAL_STARTUP_DATA)
725 int v8_natives_fd = base::GlobalDescriptors::GetInstance()->MaybeGet( 725 int v8_natives_fd = base::GlobalDescriptors::GetInstance()->MaybeGet(
726 kV8NativesDataDescriptor); 726 kV8NativesDataDescriptor);
727 int v8_snapshot_fd = base::GlobalDescriptors::GetInstance()->MaybeGet( 727 int v8_snapshot_fd = base::GlobalDescriptors::GetInstance()->MaybeGet(
728 kV8SnapshotDataDescriptor); 728 kV8SnapshotDataDescriptor);
729 if (v8_natives_fd != -1 && v8_snapshot_fd != -1) { 729 if (v8_natives_fd != -1 && v8_snapshot_fd != -1) {
730 CHECK(gin::IsolateHolder::LoadV8SnapshotFD(v8_natives_fd, 730 CHECK(gin::IsolateHolder::LoadV8SnapshotFD(v8_natives_fd,
731 v8_snapshot_fd)); 731 v8_snapshot_fd));
732 } else { 732 } else {
733 CHECK(gin::IsolateHolder::LoadV8Snapshot()); 733 CHECK(gin::IsolateHolder::LoadV8Snapshot());
734 } 734 }
735 #endif // V8_USE_EXTERNAL_STARTUP_DATA 735 #endif // V8_USE_EXTERNAL_STARTUP_DATA
736 736
737 #else 737 #else
738 CHECK(base::i18n::InitializeICU()); 738 CHECK(base::i18n::InitializeICU());
739 #ifdef V8_USE_EXTERNAL_STARTUP_DATA 739 #if defined(V8_USE_EXTERNAL_STARTUP_DATA)
740 CHECK(gin::IsolateHolder::LoadV8Snapshot()); 740 CHECK(gin::IsolateHolder::LoadV8Snapshot());
741 #endif // V8_USE_EXTERNAL_STARTUP_DATA 741 #endif // V8_USE_EXTERNAL_STARTUP_DATA
742 #endif // OS_ANDROID 742 #endif // OS_ANDROID
743 743
744 InitializeStatsTable(command_line); 744 InitializeStatsTable(command_line);
745 745
746 if (delegate_) 746 if (delegate_)
747 delegate_->PreSandboxStartup(); 747 delegate_->PreSandboxStartup();
748 748
749 if (!process_type.empty()) 749 if (!process_type.empty())
750 CommonSubprocessInit(process_type); 750 CommonSubprocessInit(process_type);
751 751
752 #if defined(OS_WIN) 752 #if defined(OS_WIN)
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
848 848
849 DISALLOW_COPY_AND_ASSIGN(ContentMainRunnerImpl); 849 DISALLOW_COPY_AND_ASSIGN(ContentMainRunnerImpl);
850 }; 850 };
851 851
852 // static 852 // static
853 ContentMainRunner* ContentMainRunner::Create() { 853 ContentMainRunner* ContentMainRunner::Create() {
854 return new ContentMainRunnerImpl(); 854 return new ContentMainRunnerImpl();
855 } 855 }
856 856
857 } // namespace content 857 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | gin/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698