Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Side by Side Diff: gin/public/isolate_holder.h

Issue 832393003: [gin] Fingerprint the V8 snapshot files on Windows and verify before loading the snapshot. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix 'all' target when v8_use_external_startup_data==0 Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« gin/isolate_holder.cc ('K') | « gin/isolate_holder.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef GIN_PUBLIC_ISOLATE_HOLDER_H_ 5 #ifndef GIN_PUBLIC_ISOLATE_HOLDER_H_
6 #define GIN_PUBLIC_ISOLATE_HOLDER_H_ 6 #define GIN_PUBLIC_ISOLATE_HOLDER_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "gin/gin_export.h" 10 #include "gin/gin_export.h"
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 // loop. This method adds a MessageLoop TaskObserver which runs any pending 44 // loop. This method adds a MessageLoop TaskObserver which runs any pending
45 // Microtasks each time a Task is completed. This method should be called 45 // Microtasks each time a Task is completed. This method should be called
46 // once, when a MessageLoop is created and it should be called on the 46 // once, when a MessageLoop is created and it should be called on the
47 // MessageLoop's thread. 47 // MessageLoop's thread.
48 void AddRunMicrotasksObserver(); 48 void AddRunMicrotasksObserver();
49 49
50 // This method should also only be called once, and on the MessageLoop's 50 // This method should also only be called once, and on the MessageLoop's
51 // thread. 51 // thread.
52 void RemoveRunMicrotasksObserver(); 52 void RemoveRunMicrotasksObserver();
53 53
54 #ifdef V8_USE_EXTERNAL_STARTUP_DATA 54 #if defined(V8_USE_EXTERNAL_STARTUP_DATA)
55 static bool LoadV8SnapshotFD(int natives_fd, int snapshot_fd); 55 static bool LoadV8SnapshotFD(int natives_fd, int snapshot_fd);
56 #if defined(OS_WIN)
57 static bool LoadAndVerifyV8Snapshot();
58 #else
56 static bool LoadV8Snapshot(); 59 static bool LoadV8Snapshot();
57 #endif // V8_USE_EXTERNAL_STARTUP_DATA 60 #endif // defined(OS_WIN)
61 #endif // defined(V8_USE_EXTERNAL_STARTUP_DATA)
58 static void GetV8ExternalSnapshotData(const char** natives_data_out, 62 static void GetV8ExternalSnapshotData(const char** natives_data_out,
59 int* natives_size_out, 63 int* natives_size_out,
60 const char** snapshot_data_out, 64 const char** snapshot_data_out,
61 int* snapshot_size_out); 65 int* snapshot_size_out);
62 66
63 private: 67 private:
68 #if defined(V8_USE_EXTERNAL_STARTUP_DATA)
69 static bool LoadV8SnapshotCommon();
70 #endif // defined(V8_USE_EXTERNAL_STARTUP_DATA)
71
64 v8::Isolate* isolate_; 72 v8::Isolate* isolate_;
65 scoped_ptr<PerIsolateData> isolate_data_; 73 scoped_ptr<PerIsolateData> isolate_data_;
66 scoped_ptr<RunMicrotasksObserver> task_observer_; 74 scoped_ptr<RunMicrotasksObserver> task_observer_;
67 75
68 DISALLOW_COPY_AND_ASSIGN(IsolateHolder); 76 DISALLOW_COPY_AND_ASSIGN(IsolateHolder);
69 }; 77 };
70 78
71 } // namespace gin 79 } // namespace gin
72 80
73 #endif // GIN_PUBLIC_ISOLATE_HOLDER_H_ 81 #endif // GIN_PUBLIC_ISOLATE_HOLDER_H_
OLDNEW
« gin/isolate_holder.cc ('K') | « gin/isolate_holder.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698