Remove Compiler.assembledCode.

pkg/compiler/lib/src/compiler.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart2js;
 
 /**
  * If true, print a warning for each method that was resolved, but not
  * compiled.
  */
@@ skipping 255 matching lines @@
 
   // The backend determines the native resolution enqueuer, with a no-op
   // default, so tools like dart2dart can ignore the native classes.
   native.NativeEnqueuer nativeResolutionEnqueuer(world) {
     return new native.NativeEnqueuer();
   }
   native.NativeEnqueuer nativeCodegenEnqueuer(world) {
     return new native.NativeEnqueuer();
   }
 
-  void assembleProgram();
+  /// Generates the output and returns the total size of the generated code.
+  int assembleProgram();
+
   List<CompilerTask> get tasks;
 
   void onResolutionComplete() {}
 
   ItemCompilationContext createItemCompilationContext() {
     return new ItemCompilationContext();
   }
 
   bool classNeedsRti(ClassElement cls);
   bool methodNeedsRti(FunctionElement function);
@@ skipping 333 matching lines @@
   static final Uri DART_CORE = new Uri(scheme: 'dart', path: 'core');
   static final Uri DART_MIRRORS = new Uri(scheme: 'dart', path: 'mirrors');
   static final Uri DART_NATIVE_TYPED_DATA =
       new Uri(scheme: 'dart', path: '_native_typed_data');
   static final Uri DART_INTERNAL = new Uri(scheme: 'dart', path: '_internal');
   static final Uri DART_ASYNC = new Uri(scheme: 'dart', path: 'async');
 
   final Stopwatch totalCompileTime = new Stopwatch();
   int nextFreeClassId = 0;
   World world;
-  String assembledCode;
   Types types;
   _CompilerCoreTypes _coreTypes;
 
   final CacheStrategy cacheStrategy;
 
   /**
    * Map from token to the first preceeding comment token.
    */
   final TokenMap commentMap = new TokenMap();
 
@@ skipping 431 matching lines @@
 
   bool get disableTypeInference => disableTypeInferenceFlag;
 
   int getNextFreeClassId() => nextFreeClassId++;
 
   void unimplemented(Spannable spannable, String methodName) {
     internalError(spannable, "$methodName not implemented.");
   }
 
   void internalError(Spannable node, reason) {
-    assembledCode = null; // Compilation failed. Make sure that we
-                          // don't return a bogus result.
     String message = tryToString(reason);
     reportDiagnosticInternal(
         node, MessageKind.GENERIC, {'text': message}, api.Diagnostic.CRASH);
     throw 'Internal Error: $message';
   }
 
   void unhandledExceptionOnElement(Element element) {
     if (hasCrashed) return;
     hasCrashed = true;
     reportDiagnostic(element,
@@ skipping 514 matching lines @@
     if (compileAll) {
       libraryLoader.libraries.forEach((LibraryElement library) {
         fullyEnqueueLibrary(library, enqueuer.codegen);
       });
     }
     processQueue(enqueuer.codegen, mainFunction);
     enqueuer.codegen.logSummary(log);
 
     if (compilationFailed) return;
 
-    backend.assembleProgram();
+    int programSize = backend.assembleProgram();
 
     if (dumpInfo) {
-      dumpInfoTask.dumpInfo();
+      dumpInfoTask.dumpInfo(programSize);

[floitsch, 2015/01/05 10:39:33]

dumpInfo(programSize) feels wrong.
task.setSize ?
task.reportSize ?

[Johnni Winther, 2015/01/05 13:54:10]

Done.

     }
 
     checkQueues();
-
-    if (compilationFailed) {
-      assembledCode = null; // Signals failure.
-    }
   }
 
   void fullyEnqueueLibrary(LibraryElement library, Enqueuer world) {
     void enqueueAll(Element element) {
       fullyEnqueueTopLevelElement(element, world);
     }
     library.implementation.forEachLocalMember(enqueueAll);
   }
 
   void fullyEnqueueTopLevelElement(Element element, Enqueuer world) {
@@ skipping 769 matching lines @@
   InterfaceType get nullType => nullClass.computeType(compiler);
 
   @override
   InterfaceType get numType => numClass.computeType(compiler);
 
   @override
   InterfaceType get stringType =>  stringClass.computeType(compiler);
 }
 
 typedef void InternalErrorFunction(Spannable location, String message);