Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 832353004: Revert of cc: Remove tile rasterize on demand for GPU rasterization (Closed)

Created:
5 years, 11 months ago by hendrikw
Modified:
5 years, 11 months ago
Reviewers:
danakj, vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Remove tile rasterize on demand for GPU rasterization (patchset #2 id:20001 of https://codereview.chromium.org/842483003/) Reason for revert: Speculative revert for https://code.google.com/p/chromium/issues/detail?id=449288 Original issue's description: > cc: Remove tile rasterize on demand for GPU rasterization > > This code was recently added and isn't needed because it signals to the tile > that it should raster on demand (checkerboard), but this will happen anyway with > the delgated renderer. > > I've also removed a test that was breaking due to the change. > > The test wasn't really testing what we thought, because we wouldn't end up > rasterizing anything with GPU, even though force was on. > > Committed: https://crrev.com/01a4b8027c2e9e678cd6afd0a97bf83807d55f5a > Cr-Commit-Position: refs/heads/master@{#311109} TBR=vmpstr@chromium.org,danakj@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/6bf7f22dd46c31ffcf72e48397edf3ec08533ad5 Cr-Commit-Position: refs/heads/master@{#311764}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
M cc/resources/tile_manager.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_pixeltest_on_demand_raster.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hendrikw
Created Revert of cc: Remove tile rasterize on demand for GPU rasterization
5 years, 11 months ago (2015-01-15 23:22:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/832353004/1
5 years, 11 months ago (2015-01-15 23:23:33 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-15 23:25:53 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6bf7f22dd46c31ffcf72e48397edf3ec08533ad5 Cr-Commit-Position: refs/heads/master@{#311764}
5 years, 11 months ago (2015-01-15 23:28:25 UTC) #4
hendrikw
5 years, 11 months ago (2015-01-15 23:33:33 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/855583002/ by hendrikw@chromium.org.

The reason for reverting is: this will conflict with vmpstr's change :(.

Powered by Google App Engine
This is Rietveld 408576698