DescriptionEnable basic IME functionality under Ash on Windows
With this CL, IMEs become functional under Ash environment on Windows.
Some optional features for Chromium internal use (e.g., IME popup window detection, RTL language detection) will be covered by subsequent CLs.
DesignDoc:
https://docs.google.com/a/chromium.org/document/d/14TBE0LoamQz_MImcNWzeTIW_lo5EUrLJwNwmCi20V1o/edit#
Note:
In this CL, ui/base/ime/win/tsf_text_store.* is not moved but copied to win8/metro_driver/ime/text_store.* in order not to break non-Aura build. That said, hereafter we will use win8/metro_driver/ime/text_store.* as primary implementation of TSF TextStore. Anyway, ui/base/ime/win/tsf_text_store.* will be removed when Aura transition is successfully completed.
I also found some style issues in win8/metro_driver/ime/text_store.cc but I'd like to fix them in subsequent CLs to keep this CL as minimum as possible.
BUG=164964
TEST=manually done on Windows 8.1
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238921
Patch Set 1 : #Patch Set 2 : More task delegation from ChromeAppViewAsh to TextServiceImpl #
Total comments: 12
Patch Set 3 : Address comment from ananta. Add text_service_delegate.h, which I forgot to upload. Style fixes. #
Total comments: 29
Patch Set 4 : rebase #Patch Set 5 : Address comment from ananta. #
Total comments: 8
Patch Set 6 : Address comment from ananta@ (Logging HRESULT, etc) #Patch Set 7 : rebase #Patch Set 8 : Fix compile error caused by missing include. #Patch Set 9 : Fix warnings (that are treated as an error) on 64-bit build #
Messages
Total messages: 22 (0 generated)
|