Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 832323003: Release nonsfi_loader_arm as a part of NaCl SDK (Closed)

Created:
5 years, 11 months ago by hamaji
Modified:
5 years, 11 months ago
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg, mazda
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Release nonsfi_loader_arm as a part of NaCl SDK TEST=./build_tools/build_sdk.py --tar TEST=trybot BUG= https://code.google.com/p/nativeclient/issues/detail?id=3851 Committed: https://crrev.com/86e2da7a24b9db13741e8a605eaf4367dad3b81d Cr-Commit-Position: refs/heads/master@{#312516}

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M native_client_sdk/src/build_tools/build_artifacts.py View 1 chunk +2 lines, -0 lines 0 comments Download
M native_client_sdk/src/build_tools/build_sdk.py View 1 1 chunk +3 lines, -2 lines 0 comments Download
M native_client_sdk/src/build_tools/sdk_files.list View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Sam Clegg
https://codereview.chromium.org/832323003/diff/1/native_client_sdk/src/build_tools/build_artifacts.py File native_client_sdk/src/build_tools/build_artifacts.py (right): https://codereview.chromium.org/832323003/diff/1/native_client_sdk/src/build_tools/build_artifacts.py#newcode247 native_client_sdk/src/build_tools/build_artifacts.py:247: 'nonsfi_loader_arm']) Why do these have the .nexe extension? Presumably ...
5 years, 11 months ago (2015-01-05 10:50:04 UTC) #2
hamaji
PTAL https://codereview.chromium.org/832323003/diff/1/native_client_sdk/src/build_tools/build_artifacts.py File native_client_sdk/src/build_tools/build_artifacts.py (right): https://codereview.chromium.org/832323003/diff/1/native_client_sdk/src/build_tools/build_artifacts.py#newcode247 native_client_sdk/src/build_tools/build_artifacts.py:247: 'nonsfi_loader_arm']) On 2015/01/05 10:50:04, Sam Clegg wrote: > ...
5 years, 11 months ago (2015-01-21 02:13:51 UTC) #4
Sam Clegg
lgtm
5 years, 11 months ago (2015-01-21 02:59:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/832323003/20001
5 years, 11 months ago (2015-01-22 00:57:34 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-22 01:35:12 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-22 01:36:16 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/86e2da7a24b9db13741e8a605eaf4367dad3b81d
Cr-Commit-Position: refs/heads/master@{#312516}

Powered by Google App Engine
This is Rietveld 408576698