Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Side by Side Diff: Source/modules/presentation/PresentationController.h

Issue 832263007: Added plumbing for the availablechange event from Blink to WebPresentationClient. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Changed the event listeners logic a bit. Addressed the comments. Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef PresentationController_h
6 #define PresentationController_h
7
8 #include "modules/presentation/Presentation.h"
9 #include "platform/Supplementable.h"
10 #include "platform/heap/Handle.h"
11 #include "public/platform/WebPresentationController.h"
12
13 namespace blink {
14
15 class LocalFrame;
16 class WebPresentationClient;
17
18 // The coordinator between the various page exposed properties and the content
19 // layer represented via |WebPresentationClient|.
20 class PresentationController final : public NoBaseWillBeGarbageCollectedFinalize d<PresentationController>, public WillBeHeapSupplement<LocalFrame>, public WebPr esentationController {
mark a. foltz 2015/01/09 00:35:10 Is there a line length limit in the Blink style gu
whywhat 2015/01/22 21:18:17 Nope, there's no limit. :( As I understand it, the
21 WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(PresentationController);
22 WTF_MAKE_NONCOPYABLE(PresentationController);
23 public:
24 virtual ~PresentationController();
25
26 static PassOwnPtrWillBeRawPtr<PresentationController> create(LocalFrame&, We bPresentationClient*);
27
28 static const char* supplementName();
29 static PresentationController* from(LocalFrame&);
30
31 static void provideTo(LocalFrame&, WebPresentationClient*);
32
33 // Implementation of HeapSupplement.
34 virtual void trace(Visitor*) override;
mark a. foltz 2015/01/09 00:35:10 Named parameter?
whywhat 2015/01/22 21:18:17 Per Blink/WebKit style guide the name that's obvio
35
36 // Implementation of WebPresentationController.
37 virtual void didChangeAvailability(bool available) override;
38
39 // Called when the first listener was added to or the last listener was remo ved from the
40 // |availablechange| event.
41 void updateAvailableChangeWatched(bool watched);
42
43 // Connects the |Presentation| object with this controller.
44 void setPresentation(Presentation*);
mark a. foltz 2015/01/09 00:35:10 Does this need a named parameter?
whywhat 2015/01/22 21:18:17 Ditto.
45
46 private:
47 PresentationController(LocalFrame&, WebPresentationClient*);
48
49 WebPresentationClient* m_client;
50 PersistentWillBeMember<Presentation> m_presentation;
51 };
52
53 } // namespace blink
54
55 #endif // PresentationController_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698