Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 832183006: revert buildbot breaker (Closed)

Created:
5 years, 11 months ago by caryclark
Modified:
5 years, 11 months ago
Reviewers:
hal.canary
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

revert buildbot breaker Hals's change broke a buildbot has shown here http://build.chromium.org/p/client.skia/builders/Test-Win7-ShuttleA-HD2000-x86-Release/builds/510/steps/gm/logs/stdio Got unknown flag "--useDocumentInsteadOfDevice". Exiting. TBR=halcanary Committed: https://skia.googlesource.com/skia/+/ac8d8b8f13aaf8e63884029c9016eae7cf463534

Patch Set 1 #

Patch Set 2 : local changes got tacked on -- revert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -466 lines) Patch
M gm/gmmain.cpp View 3 chunks +51 lines, -14 lines 0 comments Download
M gyp/pdf.gyp View 2 chunks +6 lines, -0 lines 0 comments Download
M gyp/pdf.gypi View 1 chunk +4 lines, -2 lines 0 comments Download
M gyp/tools.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A + include/pdf/SkPDFDevice.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + include/pdf/SkPDFDocument.h View 0 chunks +-1 lines, --1 lines 0 comments Download
D src/pdf/SkPDFDevice.h View 1 chunk +0 lines, -339 lines 0 comments Download
D src/pdf/SkPDFDocument.h View 1 chunk +0 lines, -113 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/832183006/1
5 years, 11 months ago (2015-01-07 13:56:15 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot/builds/1456)
5 years, 11 months ago (2015-01-07 13:57:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/832183006/20001
5 years, 11 months ago (2015-01-07 14:05:14 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-07 15:36:55 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/ac8d8b8f13aaf8e63884029c9016eae7cf463534

Powered by Google App Engine
This is Rietveld 408576698