Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 832183004: Turn on job-based recompilation (Closed)

Created:
5 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 11 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Turn on job-based recompilation BUG=v8:3608 LOG=y R=yangguo@chromium.org Committed: https://crrev.com/715552409b4a08504301cf1ad4cb2e45a815f01b Cr-Commit-Position: refs/heads/master@{#25972}

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/flag-definitions.h View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
jochen (gone - plz use gerrit)
5 years, 11 months ago (2015-01-07 09:37:47 UTC) #1
Yang
On 2015/01/07 09:37:47, jochen (OOO aka really slow) wrote: lgtm.
5 years, 11 months ago (2015-01-07 09:40:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/832183004/1
5 years, 11 months ago (2015-01-07 10:29:06 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/577)
5 years, 11 months ago (2015-01-07 11:17:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/832183004/20001
5 years, 11 months ago (2015-01-07 13:04:26 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-07 13:30:58 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/715552409b4a08504301cf1ad4cb2e45a815f01b Cr-Commit-Position: refs/heads/master@{#25972}
5 years, 11 months ago (2015-01-07 13:31:18 UTC) #10
jochen (gone - plz use gerrit)
5 years, 11 months ago (2015-01-07 14:14:31 UTC) #11
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/791033007/ by jochen@chromium.org.

The reason for reverting is: revert.

Powered by Google App Engine
This is Rietveld 408576698